Opened 5 years ago

Closed 3 years ago

#43490 closed enhancement (fixed)

mp3fs: Update and switch to osxfuse

Reported by: mf2k (Frank Schima) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cooljeanius (Eric Gallager), aserbin@…
Port: mp3fs

Description

The mp3fs port needs to switch from the obsolete and replaced_by fuse4x port to osxfuse. See #39456.

It also should be updated to the latest version - currently 0.9 - and point to the current homepage.

Attachments (2)

mp3fs.diff (1014 bytes) - added by aserbin@… 3 years ago.
Patch to switch from fuse4x to osxfuse and fix compilation under clang-700.0.72
Portfile-mp3fs.diff (1.2 KB) - added by aserbin@… 3 years ago.
Updated portfile patch: changed as suggested

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:2 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from mail@… to macports-tickets@…

Port abandoned. See #43811.

Changed 3 years ago by aserbin@…

Attachment: mp3fs.diff added

Patch to switch from fuse4x to osxfuse and fix compilation under clang-700.0.72

comment:3 Changed 3 years ago by aserbin@…

Please consider restoring the port: the patch attached is to switch mp3fs (ver 0.30) from fuse4x to osxfuse and fix compilation with Apple LLVM version 7.0.0 (clang-700.0.72).

To patch:

cd $PORTS_ROOT/fuse/mp3fs && patch -p1 < mp3fs.diff

Last edited 3 years ago by aserbin@… (previous) (diff)

comment:4 Changed 3 years ago by aserbin@…

Please see the attached file Portfile-mp3fs.diff​ to fix the ticket.

The patch addresses the following:

comment:5 Changed 3 years ago by aserbin@…

Please consider applying the attached Portfile-mp3fs.diff​ to address the ticket.

Thank you!

comment:6 Changed 3 years ago by aserbin@…

Cc: aserbin@… added

Cc Me!

comment:7 Changed 3 years ago by mf2k (Frank Schima)

Type: defectenhancement
Version: 2.2.1

Some comments:

  • Switch to using the github portgroup. This should also fix that you are hardcoding the version number in the master_sites line.
  • Use rmd160 and sha256 checksums. md5 and sha1 are obsolete and should only be included if provided upstream.

Changed 3 years ago by aserbin@…

Attachment: Portfile-mp3fs.diff added

Updated portfile patch: changed as suggested

comment:8 Changed 3 years ago by aserbin@…

Thank you for the review!

I updated the patch -- please take a look.

comment:9 Changed 3 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Thank you! r149164.

Note: See TracTickets for help on using tickets.