icoutils 0.31.0 submission

[macports@…]

New Portfile for icoutils 0.31.0

[mf2k (Frank Schima)]

By definition, a "submission" ticket means a file needs to be attached.

[mkae (Marko Käning)]

Replying to mf2k@…:

By definition, a "submission" ticket means a file needs to be attached.

Isn't there a Portfile attached?

[mf2k (Frank Schima)]

If there wasn't then it wouldn't be a submission would it?

[mkae (Marko Käning)]

Ah, ok. ;-) I've been confused. Sorry for the noise. (Just built and installed it successfully.)

[mkae (Marko Käning)]

Committed in r119589.

[mkae (Marko Käning)]

Cc Me!

[mkae (Marko Käning)]

According to ​this mailing list post some rework is needed. I'll try to take care of it.

[mkae (Marko Käning)]

Your submission requires p5-libwww-perl being in fact just a stub port, which is why I'd have to replace it by p5.16-libwww-perl.

This port has been split up in quite a few packages:

$ port notes p5.16-libwww-perl
p5.16-libwww-perl has the following notes:
  As of version 6.00, libwww-perl has been broken up into multiple packages. If you were using
  p5.16-libwww-perl for just one or two of its modules before, you may be able to pare down your
  installation to just those modules now. Other important changes have been made that may affect
  your code; for details, please see: /opt/local/share/doc/p5.16-libwww-perl/Changes

So, the question is whether you can strip down this dependency to one or a few of these:

--->  Installing p5.16-encode-locale @1.20.0_2
--->  Installing p5.16-http-date @6.20.0_0
--->  Installing p5.16-file-listing @6.20.0_2
--->  Installing p5.16-html-tagset @3.200.0_3
--->  Installing p5.16-html-parser @3.710.0_0
--->  Installing p5.16-lwp-mediatypes @6.10.0_2
--->  Installing p5.16-mime-base64 @3.140.0_0
--->  Installing p5.16-uri @1.590.0_2
--->  Installing p5.16-http-message @6.60.0_0
--->  Installing p5.16-html-form @6.0.0_2
--->  Installing p5.16-http-cookies @6.10.0_0
--->  Installing p5.16-http-daemon @6.10.0_0
--->  Installing p5.16-http-negotiate @6.10.0_0
--->  Installing p5.16-net-http @6.10.0_2
--->  Installing p5.16-www-robotrules @6.10.0_2
--->  Installing p5.16-net-ssleay @1.580.0_0
--->  Installing p5.16-net-libidn @0.120.0_3
--->  Installing p5.16-io-socket-ssl @1.981.0_0
--->  Installing p5.16-mozilla-ca @20110904_2
--->  Installing p5.16-lwp-protocol-https @6.20.0_2
--->  Installing p5.16-libwww-perl @6.60.0_0+ssl

before I proceed with this port file?!

[mkae (Marko Käning)]

OK, committed in r119617 using p5.16-libwww-perl eventually.

Please have a look at ​clang's build warnings.

I guess I keep this ticket open for now, in case you want to patch those away.

[macports@…]

Replying to mk@…:

Please have a look at ​clang's build warnings.

Thanks, mk. I will try to eliminate the build warnings and strip down the dependency.

Question from a MacPorts newbie: Why is it necessary to depend on a specific version of Perl? icoutils requires only Perl 5.6 or greater.

[macports@…]

Revision 4; adds patches that eliminate warnings

[skarulkar@…]

Adding a comment to test. -Shree

[mkae (Marko Käning)]

Adding a test comment.

[mkae (Marko Käning)]

Committed in r119625 and all 4 buildbots were happy.

Please supply Portfile diffs relative to the port's directory. That's more useful.

The patches were just fine.

Thanks, Marko

[macports@…]

Will do that in the future. Thanks.

[mkae (Marko Käning)]

Will you eye the port yourself like a hawk, or should I add myself as maintainer as well, in case there are easy-to-do updates in the queue?

[macports@…]

You should add yourself.

[mkae (Marko Käning)]

OK, done in r119756.