Opened 5 years ago

Closed 5 years ago

#43568 closed submission (fixed)

zathura @0.2.7

Reported by: harciga Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc:
Port: zathura

Description

new port

Attachments (5)

Portfile (1.7 KB) - added by harciga 5 years ago.
Portfile.2 (1.8 KB) - added by harciga 5 years ago.
Portfile.3 (1.8 KB) - added by harciga 5 years ago.
Portfile.4 (2.0 KB) - added by harciga 5 years ago.
Portfile.5 (2.0 KB) - added by harciga 5 years ago.

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by harciga

Attachment: Portfile added

comment:1 Changed 5 years ago by harciga

Whoever commits this, please also close ticket #41323

comment:2 Changed 5 years ago by ryandesign (Ryan Schmidt)

Keywords: pwmt removed

Thanks. Some observations:

  • There should be a blank line between the "# $Id$" and "PortSystem 1.0" lines.
  • The license field should be just "zlib", not "zlib License".
  • The line "distname zathura-${version}" should be removed because that is the default value.
  • The distfile name should be removed from the checksums line because there is only one file being checksummed.
  • Because you use "use_configure no", you must add code to ensure you're UsingTheRightCompiler, building with -arch flags, and if possible add a universal variant.
  • The dependency on glib2 should be written as a path-style dependency so that glib2-devel could satisfy it; see other ports depending on glib2 for how to do that.
  • The dependency on girara should be written in port-style, not lib-style, unless there is an unusual requirement here that I'm not aware of.
  • You could use the ${homepage} variable in the definition of master_sites.

comment:3 in reply to:  2 Changed 5 years ago by harciga

Replying to ryandesign@…:

Thanks. Some observations:

  • There should be a blank line between the "# $Id$" and "PortSystem 1.0" lines.

Done.

  • The license field should be just "zlib", not "zlib License".

Done.

  • The line "distname zathura-${version}" should be removed because that is the default value.

Done.

  • The distfile name should be removed from the checksums line because there is only one file being checksummed.

Done.

  • Because you use "use_configure no", you must add code to ensure you're UsingTheRightCompiler, building with -arch flags, and if possible add a universal variant.

-- UsingTheRightCompiler

I have checked the Makefile and it uses ${CC}, I also added the recommended lines for Ports with nonstandard or non-existent configure scripts https://trac.macports.org/wiki/UsingTheRightCompiler#nonstandard-ports

-- build with -arch- flags

Is this not handled by default?

-- add a universal variant

Why? §5.3.7.1 Configure Universal

There is a default universal variant made available to all ports by MacPorts base, so redefining universal keywords should only be done to make a given port compile if the default options fail to do so.

  • The dependency on glib2 should be written as a path-style dependency so that glib2-devel could satisfy it; see other ports depending on glib2 for how to do that.

Went with depends_lib path:lib/libglib-2.0.dylib:glib2

  • The dependency on girara should be written in port-style, not lib-style, unless there is an unusual requirement here that I'm not aware of.

Rewritten in path: style.

  • You could use the ${homepage} variable in the definition of master_sites.

Done.

Changed 5 years ago by harciga

Attachment: Portfile.2 added

comment:4 Changed 5 years ago by harciga

I missed ${destroot} in destroot.args

Last edited 5 years ago by harciga (previous) (diff)

Changed 5 years ago by harciga

Attachment: Portfile.3 added

comment:5 Changed 5 years ago by harciga

Ok, added -arch flags and variant universal and tested the Portfile to work correctly.

Is there anything else I should address for approval?

Changed 5 years ago by harciga

Attachment: Portfile.4 added

comment:6 Changed 5 years ago by harciga

This Portfile is not ready for submission, variant universal is not building fat binaries and -arch flags while it builds cleanly produces a misbehaving binary.

I understand variant universal can be removed and worked at a later date if fat binaries are requested, but -arch flags are a requisite for port approval because of the use_configure no directive. I have to find out what is causing the bug.

Changed 5 years ago by harciga

Attachment: Portfile.5 added

comment:7 in reply to:  6 Changed 5 years ago by harciga

universal variant is working correctly now. And the application is behaving correctly.

$ lipo -info /opt/local/bin/zathura

Architectures in the fat file: /opt/local/bin/zathura are: x86_64 i386

Let me know if there is anything left to address.

comment:8 Changed 5 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Committed in r120311 with the following changes:

  • Added missing build dependency on port:pkgconfig.
  • Added VERBOSE=1 to build.env to simplify debugging build failures in the future.
Note: See TracTickets for help on using tickets.