Opened 10 years ago

Closed 10 years ago

#43617 closed defect (fixed)

texinfo: texi2dvi incompatible with bsdsed

Reported by: Ionic (Mihai Moldovan) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mkae (Marko Käning), cooljeanius (Eric Gallager), mojca (Mojca Miklavec), drkp (Dan Ports)
Port: texinfo

Description (last modified by mojca (Mojca Miklavec))

texinfo's texi2dvi command is incompatible with bsdsed in the case of texinfo files requiring recode.

An incarnation of that can be seen in #38744.

A far as I can see, we have to options: ping upstream on this issue and hope for them to resolve the bug, or rewrite texi2dvi (and possibly other tools?!) to use "gsed" instead of just "sed".

Attachments (2)

foo.texi (244 bytes) - added by Ionic (Mihai Moldovan) 10 years ago.
Minimal testcase showcasing the bug when being converted with texi2dvi --pdf --batch foo.texi.
texinfo-norecode.diff (16.3 KB) - added by mojca (Mojca Miklavec) 10 years ago.
patch to the latest unreleased version of texi2dvi to avoid problems with sed

Download all attachments as: .zip

Change History (17)

comment:1 Changed 10 years ago by mkae (Marko Käning)

Cc: dports@… removed
Owner: changed from macports-tickets@… to dports@…

comment:2 Changed 10 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 10 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:4 Changed 10 years ago by mojca (Mojca Miklavec)

Doesn't texi2dvi belong to texinfo (non-maintained port) rather than TeX Live?

Is anyone willing to come up with a minimal example and send a bug report?

REPORTING BUGS
       Report bugs to bug-texinfo at gnu.org, general questions and discussion to help-texinfo at gnu.org.
       GNU Texinfo home page: <http://www.gnu.org/software/texinfo/>
       General help using GNU software: <http://www.gnu.org/gethelp/>

comment:5 Changed 10 years ago by Ionic (Mihai Moldovan)

Mea culpa. Indeed, it does. Would you please be so kind to remove dports and change the description + affected port to texinfo?

I blindly relied on the maxima port to get its dependencies right (obviously, it's depending on texlive for +printable_docs) and didn't even bother to double-check, whether texi2dvi is actually included in texlive.

I could try coming up with a minimal example... at least I kind-of-know what is causing this bug.

comment:6 Changed 10 years ago by mojca (Mojca Miklavec)

Cc: dports@… added
Description: modified (diff)
Owner: changed from dports@… to macports-tickets@…
Port: texinfo added; texlive removed
Summary: texlive: texi2dvi incompatible with bsdsedtexinfo: texi2dvi incompatible with bsdsed

Changed 10 years ago by Ionic (Mihai Moldovan)

Attachment: foo.texi added

Minimal testcase showcasing the bug when being converted with texi2dvi --pdf --batch foo.texi.

comment:7 Changed 10 years ago by Ionic (Mihai Moldovan)

I'm just not sure what to do with that.

Sure, texi2dvi fails with bsdsed and it doesn't with gnused. But does this mean, that it is a texinfo bug?

The baseline is bsdsed as shipped by Apple failing when being run on any input containing non-ASCII characters.

To make matters even more complicated: it fails only when LC_CTYPE is set to any UTF-8 locale BUT the input file has another charset. Running LC_CTYPE=C LANG=C texi2dvi --pdf --batch foo.texi works fine.

So... I guess texi2dvi needs some more code to detect the input file's charset and and change the LC_CTYPE and LANG environment variables accordingly to some locale supporting the detected charset... but does that make sense?

Last edited 10 years ago by Ionic (Mihai Moldovan) (previous) (diff)

comment:8 Changed 10 years ago by Ionic (Mihai Moldovan)

Upstream is not interested.

We'll have to set LC_ALL in our build environment based on the input file's encoding (and hope they don't switch between UTF-8 and other encodings for different input files.)

You may set this ticket's status to invalid.

comment:9 Changed 10 years ago by mf2k (Frank Schima)

Resolution: invalid
Status: newclosed

comment:10 Changed 10 years ago by mojca (Mojca Miklavec)

Do you have any pointers to the relevant conversation?

I would prefer to wait a tiny bit before closing this as invalid. It's not tooooo difficult to fix even if upstream disagrees to make any changes. In principle we could even "hardcode-replace" the sed with gsed to make the tool work in the first place.

comment:11 Changed 10 years ago by Ionic (Mihai Moldovan)

Pointer: Bug report answer

We could change the scripts to call gsed... but that would require to take a look at all binaries/scripts. Shall I rather do that? It would make texinfo more difficult to maintain, as one must check for new occurrences of sed in new files for instance.

comment:12 Changed 10 years ago by mojca (Mojca Miklavec)

Resolution: invalid
Status: closedreopened

Changed 10 years ago by mojca (Mojca Miklavec)

Attachment: texinfo-norecode.diff added

patch to the latest unreleased version of texi2dvi to avoid problems with sed

comment:13 Changed 10 years ago by mojca (Mojca Miklavec)

Committed in r121939. Once we confirm that it works properly the ticket may be closed.

comment:14 Changed 10 years ago by Ionic (Mihai Moldovan)

Works for me.

comment:15 Changed 10 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.