Opened 7 years ago

Last modified 4 years ago

#43662 accepted defect

indent: gnuindent -kr crashes

Reported by: jhi Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: gindent

Description (last modified by ryandesign (Ryan Schmidt))

I'm trying to reformat the Perl C source files. The macports gnuindent 2.2.10 seems to crash (as in: segfault) on some files, when I use the -kr option for K&R style. The crash is fully reproducible. I cannot see a correlation between the size of the input file and a crash. I'm attaching one of the crash-inducing files, utf8.c, here for repro. Note: if run as

gnuindent -kr utf8.c

not only there is a segfault, but the utf8.c gets truncated, too (since by default gnu indent outputs to the input file...)

I'm running the latest macports, on OS X 10.9.2.

I tried indent in a Ubuntu precise, indent --version says there 2.2.11, no crashes.

Attachments (2)

utf8.c.gz (38.2 KB) - added by jhi 7 years ago.
retrying attaching the sample file, hopefully untruncated
gnuindent_2014-06-15-112620_earth.crash (8.9 KB) - added by kurthindenburg (Kurt Hindenburg) 7 years ago.
crash file

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Summary: (GNU) indent -kr crashesindent: gnuindent -kr crashes

The utf8.c you attached is already truncated; I get:

$ gnuindent -kr utf8.c
indent: utf8.c:1828: Error:Unexpected end of file

comment:2 in reply to:  description ; Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to jhi@…:

I tried indent in a Ubuntu precise, indent --version says there 2.2.11, no crashes.

The latest version of indent on the GNU FTP site is 2.2.10. You should probably file this bug report with the developers of indent, and when they fix it and release a new version, then we can update the port in MacPorts to that version.

Changed 7 years ago by jhi

Attachment: utf8.c.gz added

retrying attaching the sample file, hopefully untruncated

comment:3 in reply to:  2 Changed 7 years ago by jhi

Replying to ryandesign@…:

Replying to jhi@…:

I tried indent in a Ubuntu precise, indent --version says there 2.2.11, no crashes.

The latest version of indent on the GNU FTP site is 2.2.10. You should probably file this bug report with the developers of indent, and when they fix it and release a new version, then we can update the port in MacPorts to that version.

(1) I could try doing that, but looks like the GNU indent hasn't had a release for five years now. I hoped the turnaround time with macports would be shorter.

(2) I think what release number the Ubuntu GNU indent is showing is a red herring: what is relevant that with the same input the GNU indent doesn't crash in there, while it does crash in macports.

comment:4 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

 % gnuindent -kr utf8.c -o utf8.output           
[1]    79051 segmentation fault  gnuindent -kr utf8.c -o utf8.output

-rw-r--r--  1 kurthindenburg  staff   135K Jun 15 11:26 utf8.c
-rw-r--r--  1 kurthindenburg  staff    56K Jun 15 11:26 utf8.output

Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

crash file

comment:5 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 4 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv
Port: gindent added; indent removed
Status: newaccepted

I still see this crash with 2.2.11.

Note: See TracTickets for help on using tickets.