Opened 10 years ago

Closed 9 years ago

#43677 closed submission (fixed)

py-pyne @0.4 add port

Reported by: cameron.r.bates@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: petrrr
Port: py-pyne

Description


Attachments (3)

Portfile.2 (1.2 KB) - added by mf2k (Frank Schima) 10 years ago.
main.log (84.2 KB) - added by mf2k (Frank Schima) 10 years ago.
Portfile (1.2 KB) - added by cameron.r.bates@… 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Comments:

  • The maintainers line cannot be blank. For no maintainer you would put:

maintainers nomaintainer

  • The distfiles line should not be set directly. Based on your distname, you can just delete the line because that is the distfiles line that would be generated.
  • It looks like the version is actually 0.4-rc1. Is that correct? Use that as the version.
  • You are hard coding the version number in the distname and that is not correct. You should be using:

distname ${realname}-${version}

comment:2 Changed 10 years ago by cameron.r.bates@…

I updated the maintainers and distname as suggested but if I try and remove the distfiles line it looks for pyne-0.4-rc1.tar.gz instead of 0.4-rc1.tar.gz.

comment:3 Changed 10 years ago by mf2k (Frank Schima)

That's an odd archive name. In any event, then the distname is incorrect and simply needs to be "${version}".

comment:4 in reply to:  3 Changed 10 years ago by cameron.r.bates@…

Replying to mf2k@…:

That's an odd archive name. In any event, then the distname is incorrect and simply needs to be "${version}".

So github is a bit funny the way it packages archives. The archive is hosted at ${version}${extract.suffix} but that points to an archive that is actually downloaded as ${realname}-${version}${extract.suffix} because of this changing distname to anything else will lead the build to fail as far as I can tell.

comment:5 Changed 10 years ago by mf2k (Frank Schima)

I should have noticed that. This port should use the github portgroup which handles all of these quirks. See the OpenBLAS port, among many others, for an example of how to implement that.

comment:6 in reply to:  5 Changed 10 years ago by cameron.r.bates@…

Replying to mf2k@…:

I should have noticed that. This port should use the github portgroup which handles all of these quirks. See the OpenBLAS port, among many others, for an example of how to implement that.

Using the github portgroup made everything much simpler. Should be good for another look now.

comment:7 Changed 10 years ago by cameron.r.bates@…

Anything else that is needed before this can be merged?

comment:8 Changed 10 years ago by mf2k (Frank Schima)

This does not work for me. I had to manually set the name to py-pyne and then I hit an error. My Portfile attached along with my main.log.

Changed 10 years ago by mf2k (Frank Schima)

Attachment: Portfile.2 added

Changed 10 years ago by mf2k (Frank Schima)

Attachment: main.log added

comment:9 Changed 10 years ago by cameron.r.bates@…

The build is failing because it can't find the cython binary. We're working on a fix for our cmake script right now. I'll update the Portfile as soon as it's been merged.

Changed 10 years ago by cameron.r.bates@…

Attachment: Portfile added

comment:10 Changed 10 years ago by cameron.r.bates@…

The build issue should be fixed now.

comment:11 Changed 10 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:12 Changed 9 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.2.1

Sorry for the delay. Added in r127990 with the following changes:

  • Used the hdf5 port instead of the obsolete hdf5-18.
  • Per latest python policy, removed the py33 sub-port.
Note: See TracTickets for help on using tickets.