Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#43736 closed update (fixed)

tagainijisho: update to 1.0.2

Reported by: ryandesign (Ryan Schmidt) Owned by: rudloff@…
Priority: Normal Milestone:
Component: ports Version: 2.2.99
Keywords: haspatch Cc:
Port: tagainijisho

Description

This patch updates tagainijisho to 1.0.2.

The additional change in patch-pack-CMakeLists.txt.diff fixes an error where the destroot fails because it tries to write a file directly into the applications directory, bypassing the destroot. I've reported this to the developers here: https://github.com/Gnurou/tagainijisho/issues/104

The new patch patch-i18n-CMakeLists.txt.diff fixes an error where the destroot fails when the path to the source code contains an underscore (which in MacPorts it always does) due to an overly greedy regular expression. I've reported this to the developers here: https://github.com/Gnurou/tagainijisho/issues/103

If you have no objections, I can commit this update for you.

Attachments (4)

tagainijisho-1.0.2.diff (1.2 KB) - added by ryandesign (Ryan Schmidt) 5 years ago.
proposed patch
patch-CMakeLists.txt.diff (639 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.
patch-i18n-CMakeLists.txt.diff (428 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.
patch-pack-CMakeLists.txt.diff (924 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by ryandesign (Ryan Schmidt)

Attachment: tagainijisho-1.0.2.diff added

proposed patch

Changed 5 years ago by ryandesign (Ryan Schmidt)

Attachment: patch-CMakeLists.txt.diff added

Changed 5 years ago by ryandesign (Ryan Schmidt)

Changed 5 years ago by ryandesign (Ryan Schmidt)

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

r120293 (maintainer timeout)

comment:2 Changed 5 years ago by ryandesign (Ryan Schmidt)

The build failed on the Mavericks buildslave:

Error: org.macports.activate for port tagainijisho returned: Image error: /Applications/MacPorts/Tagaini Jisho.app/Contents/Resources/qt.conf already exists and does not belong to a registered port.  Unable to activate port tagainijisho. Use 'port -f activate tagainijisho' to force the activation.

So, tagainijisho now provides qt.conf, whereas before, the file was installed bypassing the destroot. So we need to remove that file in pre-activate if found. Done in r120294.

Note: See TracTickets for help on using tickets.