poedit: update to 1.6.5

[mojca (Mojca Miklavec)]

I would like to request updating poedit (I get weird errors with the old version).

[mojca (Mojca Miklavec)]

Sorry, my patch isn't complete. It fails with

checking for Berkeley DB >= 4.7 (C++)... not found
configure: error: cannot find required Berkeley DB >= 4.7

The function AX_BERKELEY_DB_CXX in admin/berkeley_db.m4 could be improved a bit to allow specifying flags to configure to help locating the library.

And also complains about:

configure: WARNING: unrecognized options: --disable-transmem, --without-sparkle

[mojca (Mojca Miklavec)]

This is what current version throws when updating translations from pot:

/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/include/wx-3.0/wx/strvararg.h(451): assert "(argtype & (wxFormatStringSpecifier<T>::value)) == argtype" failed in wxArgNormalizer(): format specifier doesn't match argument type

Call stack:
[00] int wxString::Printf<unsigned long, unsigned long>(wxFormatString const&, unsigned long, unsigned long) 
[01] MergeSummaryDialog::TransferTo(wxArrayString const&, wxArrayString const&) 
[02] Catalog::ShowMergeSummary(Catalog*)     
[03] Catalog::UpdateFromPOT(wxString const&, bool, bool) 
[04] PoeditFrame::UpdateCatalog(wxString const&) 
[05] PoeditFrame::OnUpdate(wxCommandEvent&)  
[06] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) 
[07] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) 
[08] wxEvtHandler::TryHereOnly(wxEvent&)     
[09] wxEvtHandler::TryBeforeAndHere(wxEvent&) 
[10] wxEvtHandler::ProcessEventLocally(wxEvent&) 
[11] wxEvtHandler::ProcessEvent(wxEvent&)    
[12] wxWindowBase::TryAfter(wxEvent&)        
[13] wxEvtHandler::ProcessEvent(wxEvent&)    
[14] wxEvtHandler::SafelyProcessEvent(wxEvent&) 
[15] wxWindowBase::HandleWindowEvent(wxEvent&) const 
[16] wxMenuBase::SendEvent(int, int)         
[17] wxMenu::HandleCommandProcess(wxMenuItem*, wxWindow*) 
[18] -[wxNSMenuItem clickedAction:]          
[19] -[NSObject performSelector:withObject:] 
[20] -[NSApplication sendAction:to:from:]    
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.

[raimue (Rainer Müller)]

Here is the diff I had locally after I tried to update poedit to 1.6.3 some time ago. However, I did not succeed.

[mojca (Mojca Miklavec)]

Thank you. I'm working on upgrading LucenePlusPlus now which is a requirement for building Poedit (version in MacPorts is too old). The version currently in MacPorts already breaks on 10.6. The new version sometimes breaks with some very weird error (it looks as if the build process tries to create a file with the same name as existing folder), but it looks like out-of-source build helps.

[raimue (Rainer Müller)]

Ah, sorry, forget about that Portfile for LucenePlusPlus. Turns out I already committed this to the ports tree in r116573.

[mojca (Mojca Miklavec)]

I know that the Portfile exists, but Poedit now complains that it's too old. Can you please check the attachment (feel free to commit it)? It compiles for me, but it includes a lot less files than version 3.0.4, so I would like a second pair of eyes to confirm that out-of-source build for lucene++ works as expected.

[mojca (Mojca Miklavec)]

However I'm relatively pessimistic about Poedit.

The following looks as if C++11 is now required, so we're pretty much stuck with OS X 10.9 only.

In file included from attentionbar.cpp:26:
./attentionbar.h:66:18: error: no type named 'function' in namespace 'std'
    typedef std::function<void()> Callback;
            ~~~~~^

[raimue (Rainer Müller)]

The proposed update for LucenePlusPlus fails to build on my system.

:info:build cd /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/src/test && /usr/bin/clang++   -DLPP_EXPOSE_INTERNAL -pipe -Os -arch x86_64 -stdlib=libc++  -DNDEBUG -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -mmacosx-version-min=10.9 -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/include -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/ThirdParty/src/googletest/include -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/include -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/src/core/include -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/src/contrib/include -I/opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/src/test/include -I/opt/local/include    -fPIC -o CMakeFiles/lucene++-tester.dir/util/SimpleLRUCacheTest.cpp.o -c /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/src/test/util/SimpleLRUCacheTest.cpp
:info:build /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/LucenePlusPlus-3.0.6/src/test/util/LuceneTestFixture.cpp:24:9: error: destructor '~LuceneTestFixture' must not return void expression
:info:build         FAIL() << "ConcurrentMergeScheduler hit unhandled exceptions";
:info:build         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/ThirdParty/src/googletest/include/gtest/gtest.h:1877:17: note: expanded from macro 'FAIL'
:info:build # define FAIL() GTEST_FAIL()
:info:build                 ^
:info:build /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/ThirdParty/src/googletest/include/gtest/gtest.h:1872:22: note: expanded from macro 'GTEST_FAIL'
:info:build #define GTEST_FAIL() GTEST_FATAL_FAILURE_("Failed")
:info:build                      ^
:info:build /opt/local/var/macports/build/_Users_raimue_src_macports_trunk_dports_devel_LucenePlusPlus/LucenePlusPlus/work/build/ThirdParty/src/googletest/include/gtest/internal/gtest-internal.h:1032:3: note: expanded from macro 'GTEST_FATAL_FAILURE_'
:info:build   return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure)
:info:build   ^
:info:build 1 error generated.
:info:build make[2]: *** [src/test/CMakeFiles/lucene++-tester.dir/util/LuceneTestFixture.cpp.o] Error 1

Maybe we should even start a new ticket for this port update...

[mojca (Mojca Miklavec)]

Yes, if it fails to build for you, feel free to open a new ticket. I cannot test anyway.

[cooljeanius (Eric Gallager)]

Cc Me!

[raimue (Rainer Müller)]

In e70cecc5b3e9ffe4fcaf4d61dd781872833bd06d/macports-ports:

poedit: Remove outdated port

poedit upstream is now at 2.0.4, years ahead of 1.5.7 provided by this
port. Attempts to update the port to a more current version, feature
complete with the official upstream version, were initially blocked by
missing dependencies in MacPorts. I also have not used the software in
a long time myself, so that adds lack of interest on my side.

Providing such an old and outdated version via MacPorts has no value and
I am therefore removing this port from the ports tree. If you are
interested in an update, feel free to revive the port and take the
maintainer role.

Closes: #43772

[l2dy (Zero King)]

poedit @2.0.7 added in [438bed1dafbb47ae0dd3597dd1b3a08ffd9013c3/macports-ports], supporting macOS >= 10.11.