Transmission @2.82: update to 2.83.

[cartasegna.luca@…]

Trying to build transmission @2.83 fails for me with this error:

:info:build clang: error: no such file or directory: '/opt/local/var/macports/build/_opt_macports_ports_net_transmission/transmission/work/transmission-2.83/macosx/ShareToolbarItem.m'

and indeed that file does not exist. Opening the Xcode project with Xcode I see that there are references to four files(ShareToolbarItem.h, ShareToolbarItem.m, ShareTorrentFileHelper.h and ShareTorrentFileHelper.m) that are not present in the downloaded archive(there are no such references for the version 2.82). I guess that these files are related to the following change introduced in version 2.83 for the Mac Client:

Share option in File menu and context menu

and where added/changed in bug reports upstream ​5584 and ​5576 between version 2.82 and 2.83. The compilation finishes successfully if those four files are manually placed in the appropriate folder(/opt/local/var/macports/build/_opt_macports_ports_net_transmission/transmission/work/transmission-2.83/macosx/).

[kurthindenburg (Kurt Hindenburg)]

Thanks - so the .tar.xz file doesn't have the needed files? - did you open a bug report on the transmission site?

[cartasegna.luca@…]

Replying to khindenburg@…:

Thanks - so the .tar.xz file doesn't have the needed files? - did you open a bug report on the transmission site?

Yes, those four files are missing from the archive(but are present in SVN). I tried first on IRC but could' t get a clear answer: I had to leave and I' m unable to find logs/archive to see if I got a response after I left. I opened a bug upstream that is pending approval/moderation.

[cartasegna.luca@…]

Upstream fixed the bug:​5724.
The latest nightly tarball(transmission-trunk-r14300.tar.xz) contains the fix and the missing files. They have not updated yet the archive for version 2.83 and I' m not sure they are going to do it.

[kurthindenburg (Kurt Hindenburg)]

Great, thanks for taking care of this. I hope they'd release a new tar file

If they do re-release 2.83, we can use ​https://trac.macports.org/wiki/PortfileRecipes#stealth-updates

It would easier if they release 2.84.

If all else fails, we could use the nightly tar file

[cartasegna.luca@…]

I don' t think they are gonna re-release version 2.83...
I see four possibilities:
1) Don't update the port to version 2.83(stay with version 2.82) and the make the jump directly to version 2.84 when it is released.
2) Update the port to 2.83 using the broken archive and then copy/paste the missing files within the Portfile(not sure if it is possible).
3) Use a nightly tarball as archive and change the version to 2.83+ or devel and then "re-sync" when version 2.84 is released.
4) For version 2.83 use a SVN checkout instead of fetching the archive(as there are no files missing in SVN) and revert back to fetching the archive when version 2.84 is released.

[kurthindenburg (Kurt Hindenburg)]

I asked on IRC - could you reply on the bt bug, asking for a new tar/version?

As far as the options, I think #1 or #4 - I would really like them to fix their issue.

[kurthindenburg (Kurt Hindenburg)]

Let's wait for 2.84 from them

<jordan> khindenburg: yes we'll probably do a 2.84, there are two important bugfixes that need to land first

[kurthindenburg (Kurt Hindenburg)]

updated to 2.84 r121619