#44188 closed defect (fixed)
clang-*: fix python usage.
| Reported by: | Ionic (Mihai Moldovan) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | jeremyhu (Jeremy Huddleston Sequoia), cooljeanius (Eric Gallager) |
| Port: | clang-2.9 clang-3.0 clang-3.1 clang-3.2 clang-3.3 clang-3.4 clang-3.5 |
Description
Updating my system in trace mode, I found that clang-3.3 wouldn't build.
The default variant is python27. This is also adding --with-python=${prefix}/bin/python$PYTHON_VERSION to configure.args.
However, port:python${python_ver} was only added as a runtime dependency and thus shadowed at build time due to trace mode. As arguments given to configure via --with-* are fatal errors when not found, configure failed.
While the other ports (anything but 3.3) don't specify --with-python, let us fix them still.
clang-2.9: add build time dependency on the via variant selected python version.clang-3.0: see aboveclang-3.1: see aboveclang-3.2: see aboveclang-3.3: add build time dependency on the via variant selected python version. Here, a failure to do so is actually fatal.clang-3.4: move dependency onport:python27to lib dependencies. Also add--with-pythonas in clang-3.3. Revbump.clang-3.5: see above
(Note that --with-python has been introduced with clang 3.4.)
I will upload individual patches and a big, merged one. Take whatever you like.
Attachments (10)
Change History (17)
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-all-python.patch added |
|---|
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-2.9-python.patch added |
|---|
Patch against clang 2.9 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.0-python.patch added |
|---|
Patch against clang 3.0 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.1-python.patch added |
|---|
Patch against clang 3.1 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.2-python.patch added |
|---|
Patch against clang 3.2 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.3-python.patch added |
|---|
Patch against clang 3.3 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.4-python.patch added |
|---|
Patch against clang 3.4 Portfile.
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | llvm-3.5-python.patch added |
|---|
Patch against clang 3.5 Portfile.
comment:1 Changed 10 years ago by Ionic (Mihai Moldovan)
And just in case you won't believe me, I'm also attaching the main.log and config.log of the unpatched clang 3.3 (built with +analyzer+arm_runtime+python27.)
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | config.log.bz2 added |
|---|
Changed 10 years ago by Ionic (Mihai Moldovan)
| Attachment: | main.log.bz2 added |
|---|
comment:2 Changed 10 years ago by Ionic (Mihai Moldovan)
N.B. I didn't revbump llvm/clang < 3.4. It didn't feel necessary, as configure is not even checking for python. Feel free to do so, however, if you see the need to.
comment:3 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 10 years ago by cooljeanius (Eric Gallager)
The configure.args-append line added to the llvm-3.4 port and the llvm-3.5 port is different between the two of them; the llvm-3.5 one is missing a decimal point in the name of the python binary
Merged patch against clang 2.9, 3.0, 3.1, 3.2, 3.3, 3.4 and 3.5.