Opened 10 years ago

Closed 10 years ago

#44195 closed defect (fixed)

pidgin-bot-sentry: fix livecheck, license, mode line

Reported by: dbevans (David B. Evans) Owned by: nefar@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: pidgin-bot-sentry

Description

The attached patch fixes livecheck and adds a license line as well as a mode line. Tabs have been reformatted to conform to the mode line specification.

Please advise if this is OK to commit.

Attachments (1)

patch-pidgin-bot-sentry.diff​ (757 bytes) - added by dbevans (David B. Evans) 10 years ago.
Proposed patch to pidgin-bot-sentry Portfile

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by dbevans (David B. Evans)

Attachment: patch-pidgin-bot-sentry.diff​ added

Proposed patch to pidgin-bot-sentry Portfile

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Keywords: haspatch added

This sounds like an enhancement to me. Defect tickets are generally for build errors.

comment:2 in reply to:  1 Changed 10 years ago by dbevans (David B. Evans)

Resolution: → fixed
Status: new → closed

Replying to mf2k@…:

This sounds like an enhancement to me. Defect tickets are generally for build errors.

Probably doesn't make much difference one way or the other, but I was thinking that a defective livecheck is a defect. I see defect as anything that doesn't work the way it is expected to. Enhancement sounds like adding features to something that isn't broken.

Patch committed in r121714, maintainer timeout.

Note: See TracTickets for help on using tickets.