Changes between Initial Version and Version 1 of Ticket #44236, comment 11


Ignore:
Timestamp:
Oct 26, 2014, 11:27:13 PM (10 years ago)
Author:
mkae (Marko Käning)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #44236, comment 11

    initial v1  
     1Thanks Nicolas for looking at this!
     2
    13Replying to [comment:10 nicos@…]:
    24> If you tested it, you are free to commit it.
    … …  
    79
    810> - the port uses the plasma version 4.11.12, which is distributed with KDE 4.14, and Macports is still at 4.13. Shouldn't 4.11.11 be used?
    9 Well, I guess René might have had a reason, why he decided to go for the newer one, but I'll test the 4.11.12 version before committing this.
     11Well, I guess René might have had a reason, why he decided to go for the newer one... But I've successfully tested the 4.11.11 version before committing this.
    1012
    1113> - the email of the maintainer is not obfuscated
    12 I did so in my local version of this port file.
     14I already did so in my local version of this port file.
    1315
    1416> - phonon is already a dependency of the portgroup kde4 1.1
    1517> - the variant can be simplified in syntax. No need to separate the variant and its effects.
    16182x yep.
     19
     20Committed in r127391.
     21
     22Greets,
     23Marko