Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#44284 closed enhancement (fixed)

python-related: switch from py*-pil to path-based dependency (openmaintainer)

Reported by: Ionic (Mihai Moldovan) Owned by: petrrr
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: petrrr, maehne (Torsten Maehne)
Port: gramps asymptote comix ipe-tools py-opengl py-reportlab py-spyder-devel py-spyder py-astlib

Description (last modified by petrrr)

In accordance with communication on the MP users mailing list, I have changed py*-pil dependencies to path:-based ones satisfiable by both py*-pil and py*-Pillow.

This patchset is tracking and targeted at maintained openmaintainer ports.

(Not CC'ing maintainers, as I have sent them eMails individually and people don't need to be bothered for other stuff but their own ports.)

asymptote mojca@ done committed in r121918
comix perry@acceptedon mention it's openmaintainer, r122193
gramps devans@ done dependency on py-pil replaced with py-Pillow in upgrade to version 4.0 r121866
gramps3 devans@ done r121867
ipe-tools Torsten.Maehne@ et al. accepted committed in r122242
py-astlib aronnax@ accepted made openmaintainer, r122243
py-opengl jmr@ done committed in r121942
py-reportlab stromnov@ done committed in r121845, ticket #44249
py-spyder eborisch@ accepted r122243
py-spyder-devel eborisch@ accepted r122243

Attachments (1)

python-pil-pillow-openmaintainer.diff (8.7 KB) - added by Ionic (Mihai Moldovan) 10 years ago.
Switch from py*-pil to path:-based dependency satisfiable by both py*-pil and py*-Pillow. Fix issue reported by ipe-tools maintainer. Add Pillow compat patches to comix.

Download all attachments as: .zip

Change History (36)

comment:1 Changed 10 years ago by Ionic (Mihai Moldovan)

  • asymptote (mojca): accepted

comment:2 Changed 10 years ago by petrrr

Description: modified (diff)

comment:3 Changed 10 years ago by petrrr

Owner: changed from macports-tickets@… to petr@…

comment:4 Changed 10 years ago by petrrr

Is there a revision bump needed here? The content of the package does not change, and once the dependency is in place it does not change either. So revision bump has no real effect on the files installed.

comment:5 Changed 10 years ago by Ionic (Mihai Moldovan)

I assumed that the registry is saving dependencies given at install-time as well. Seems to have been wrong, only ports are recorded. In that case, yes, a revbump is not needed.

I'll update the patches.

comment:6 Changed 10 years ago by petrrr

Okay, I was not considering the registry. Not sure if something changes there. Maybe ask at the MP developer list for details or what impact the change has on the registry status.

comment:7 Changed 10 years ago by Ionic (Mihai Moldovan)

I did ask neverpanic, he should know this stuff. :) Waiting for a reply, but I'm pretty sure the registry will be unimpressed, as dependencies are not added literally, only port-based (and we don't really change the dependencies for already installed ports anyway.)

comment:8 Changed 10 years ago by Ionic (Mihai Moldovan)

py-reportlab (stromnov): committed in r121845 (ticket #44249)

comment:9 Changed 10 years ago by petrrr

BTW, why do you not use always there more compact path:${python.pkgd}/PIL version?

comment:10 Changed 10 years ago by petrrr

Description: modified (diff)

comment:11 Changed 10 years ago by Ionic (Mihai Moldovan)

I can't. python.pkgd is only defined by the python PortGroup. Trust me, you don't want to use the python PortGroup for non-Python-apps... (it sets build.cmd, use_configure no and other stuff...)

comment:12 Changed 10 years ago by petrrr

Okay, sorry! Have not looking into the details

comment:13 Changed 10 years ago by maehne (Torsten Maehne)

Cc: Torsten.Maehne@… added

Cc Me!

comment:14 Changed 10 years ago by Ionic (Mihai Moldovan)

Updated patch to fix the issue reported by ipe-tools maintainer, remove revbumps and py-reportlab.

ipe-toolsTorsten.Maehne@*** et alaccepted-
py-spydereborisch@accepted-
py-spyder-develeborisch@accepted-

N.B.: I'd update the original report myself, but normal users are not allowed to do this

Last edited 10 years ago by Ionic (Mihai Moldovan) (previous) (diff)

comment:15 Changed 10 years ago by dbevans (David B. Evans)

Description: modified (diff)

comment:16 Changed 10 years ago by petrrr

Description: modified (diff)

comment:17 Changed 10 years ago by dbevans (David B. Evans)

Description: modified (diff)

gramps, gramps3 fixed in r121866, r121867. gramps is py-Pillow only due to need for python 3 support.

comment:18 Changed 10 years ago by dbevans (David B. Evans)

Description: modified (diff)

comment:19 Changed 10 years ago by Ionic (Mihai Moldovan)

This patchset update fixes comix and py-opengl by adding a Pillow compat patch and py-xhtml2pdf by updating to the newest version 0.0.6, which is compatible with both PIL and Pillow.

comment:20 Changed 10 years ago by petrrr

Please move the py-xhtml2pdf update to a separate ticket and add reference to this one.

comment:21 Changed 10 years ago by mojca (Mojca Miklavec)

Description: modified (diff)

asymptote committed in r121918

comment:22 Changed 10 years ago by Ionic (Mihai Moldovan)

py-xhtml2pdf will be handled in #44309. Can be removed from this ticket. Patchset will be updated soon.

comment:23 Changed 10 years ago by petrrr

Description: modified (diff)
Port: py-xhtml2pdf removed

comment:24 Changed 10 years ago by Ionic (Mihai Moldovan)

comixperry@acceptedon mention it's openmaintainer
Last edited 10 years ago by Ionic (Mihai Moldovan) (previous) (diff)

comment:25 Changed 10 years ago by petrrr

Description: modified (diff)

comment:26 Changed 10 years ago by Ionic (Mihai Moldovan)

py-opengljmr@donecommitted r121942

Changed 10 years ago by Ionic (Mihai Moldovan)

Switch from py*-pil to path:-based dependency satisfiable by both py*-pil and py*-Pillow. Fix issue reported by ipe-tools maintainer. Add Pillow compat patches to comix.

comment:27 Changed 10 years ago by Ionic (Mihai Moldovan)

Seems like everyone either consented or committed themselves.

I'd go ahead and commit this updated bulk patch.

comment:28 Changed 10 years ago by petrrr

comix done in r122193. I guess the port would deserve further maintenance. It should either support multiple python versions via variants or just switch to python27. It installs but some run time warnings appear. Not further tested.

comment:29 Changed 10 years ago by petrrr

ipe-tools done in r122242.

I have rewritten the python related part to avoid code replication. It is a sort of python app recipe and inspired by the Fortran recipe and the Python portgroup. No revision should be needed here as the installed files remain unchanged.

comment:30 Changed 10 years ago by petrrr

Description: modified (diff)

comment:31 Changed 10 years ago by petrrr

Description: modified (diff)

comment:32 Changed 10 years ago by petrrr

ports py-spyder-devel py-spyder py-astlib done in r122243.

comment:33 Changed 10 years ago by petrrr

Description: modified (diff)
Resolution: fixed
Status: newclosed

comment:34 Changed 10 years ago by Ionic (Mihai Moldovan)

Oh, the ipe-tools commit looks very interesting. It's generating python variants on the fly. Nice work!

comment:35 in reply to:  34 Changed 10 years ago by petrrr

Replying to ionic@…:

Oh, the ipe-tools commit looks very interesting. It's generating python variants on the fly. Nice work!

It's an attempt for a pattern, which could be used either in an portgroup or at least an recipe. The portgroup needs to deal with delayed evaluation and probable requires some more work.

Note: See TracTickets for help on using tickets.