Changes between Initial Version and Version 1 of Ticket #44654, comment 5


Ignore:
Timestamp:
Dec 15, 2014, 4:44:23 PM (10 years ago)
Author:
mojca (Mojca Miklavec)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #44654, comment 5

    initial v1  
    44}}}
    55Maybe the first sort could go away (or this one could be moved elsewhere), but I'm not sure how to properly fix the code.
     6
     7We could probably remove `sort` from here at least (I just noticed that I added that sort myself, but I added it at the wrong location):
     8{{{
     9#!patch
     10--- cpan2port   (revision 129562)
     11+++ cpan2port   (working copy)
     12@@ -242,7 +242,7 @@
     13              my @depends_build = Huggy::uniq map {
     14                  MSG::warn "$$info{name} build_requires $_";
     15                  'port:'.Huggy::from_port $_
     16-             } sort(keys %{ $dep_ref });
     17+             } keys %{ $dep_ref };
     18              if (@depends_build) {
     19                  unshift(@depends_build, '    depends_build-append');
     20                  $depends_build = join(" \\\n".(' 'x20), sort(@depends_build))."\n";
     21@@ -252,7 +252,7 @@
     22              my @depends_lib = Huggy::uniq map {
     23                  MSG::warn "$$info{name} requires $_";
     24                  'port:'.Huggy::from_port $_
     25-             } sort(keys %{ $dep_ref });
     26+             } keys %{ $dep_ref };
     27              if (@depends_lib) {
     28                  unshift(@depends_lib, '    depends_lib-append');
     29                  $depends_lib = join(" \\\n".(' 'x20), sort(@depends_lib))."\n";
     30}}}