Opened 6 years ago

Closed 5 years ago

#44655 closed enhancement (fixed)

patch for KDE's AuthServicesBackend

Reported by: RJVB (René Bertin) Owned by: NicosPavlov
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: kdelibs4

Description

I changed the OS X AuthServiesBackend so that it doesn't use a helper (dbus). This allows applications to gain privileges using the OS X security manager, which doesn't seem to work through dbus. As a result, I can now save my kwallet configuration through the KDE systemsettings (in the kde4-workspace port).

This correction/enhancement consists of a modification to the patch-cmake-modules-KDE4Macros.cmake.diff file, as well as a new patch to AuthServicesBackend.cpp .

Attachments (2)

patch-cmake-modules-KDE4Macros.cmake.diff.diff (1.4 KB) - added by RJVB (René Bertin) 6 years ago.
NB diff for port dir kdelibs4/files/patch-cmake-modules-KDE4Macros.cmake.diff !
AuthServicesBackend.patch (6.4 KB) - added by RJVB (René Bertin) 6 years ago.
diff for AuthServicesBackend.cpp and kauthaction.cpp

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by RJVB (René Bertin)

NB diff for port dir kdelibs4/files/patch-cmake-modules-KDE4Macros.cmake.diff !

comment:1 Changed 6 years ago by neverpanic (Clemens Lang)

Cc: nicos@… removed
Owner: changed from macports-tickets@… to nicos@…
Type: defectenhancement

This should probably also go to upstream then? Did you already file a ticket there? If not, will you? Or should nicos do that?

Changed 6 years ago by RJVB (René Bertin)

Attachment: AuthServicesBackend.patch added

diff for AuthServicesBackend.cpp and kauthaction.cpp

comment:2 Changed 6 years ago by RJVB (René Bertin)

Filing something upstream will be my next project. As you know KDE will ask to file a Review Request that'll have to be against git/head, so I'll first have to see to what extent my modifications carry over unmodified, what with the transition to KDE 5 ...

comment:3 Changed 6 years ago by RJVB (René Bertin)

However, from what I've seen these mods should apply to KDE 4.13, if that's what we'll get before the jump to KDE 5 . NB: this concerns the *source* files; I didn't check the CMakeLists.txt files!

Edit: after applying my patches (these, and the Keychain patches) to kdelibs git/master (4.14.60 or so) and filing a Review Request to include them upstream (https://git.reviewboard.kde.org/r/119838/), my disclaimer about the cmake files can be disregarded, I think :)

Last edited 6 years ago by RJVB (René Bertin) (previous) (diff)

comment:4 Changed 6 years ago by NicosPavlov

I am considering upgrading Macports KDE to 4.13 soon, and am starting to look at the improvements to include, so this one could be integrated at that time. I may however do things in two steps, first upgrading and then including improvements, in order to ease the detection of glitches.

One thing is that you are mentioning kde4-workspace, which is not part of Macports presently. So this part would require committing #44236, right?

comment:5 Changed 6 years ago by RJVB (René Bertin)

Hmm, I'd appreciate it if you could do that 2-step upgrade locally, and publish the upgrade as if it were in a single step. Although I guess I could add my own improvements to a local port copy ...

As to kde4-workspace: its presence is not required for "this part", it just has components that benefit from these patches. Of course, if you don't commit that kde4-workspace, I'd be "forced" to update my own kde4-workspace port ...

How fitting to upgrade to 4.13 just as 4.14 is about to be released ;)

Last edited 6 years ago by RJVB (René Bertin) (previous) (diff)

comment:6 Changed 6 years ago by mkae (Marko Käning)

I'll have a look into these in a week or so.

comment:7 Changed 5 years ago by NicosPavlov

Resolution: fixed
Status: newclosed

Committed in r126340 along with 4.13.3 update.

Note: See TracTickets for help on using tickets.