mspdebug @0.22_1: build fails with GNU Make 3.80

[lars.haulin@…]

Building fails under OS X 10.4 with Xcode 2.5 with the following log message:

:debug:build Executing command line:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_mspdebug/mspdebug/work/mspdebug-0.22" && /usr/bin/make -j2 -w all CC="/opt/local/bin/gcc-apple-4.2 -arch i386" 
:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_mspdebug/mspdebug/work/mspdebug-0.22'
:info:build Makefile:67: Extraneous text after `else' directive
:info:build Makefile:70: *** only one `else' per conditional.  Stop.
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_mspdebug/mspdebug/work/mspdebug-0.22'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_mspdebug/mspdebug/work/mspdebug-0.22" && /usr/bin/make -j2 -w all CC="/opt/local/bin/gcc-apple-4.2 -arch i386" 
:info:build Exit code: 2
:error:build org.macports.build for port mspdebug returned: command execution failed

This have to do with the the older version of Make that comes with Xcode 2.5; repeated else conditionals were first introduced in GNU Make Version 3.81

$ /usr/bin/make -v
GNU Make 3.80

I got this to compile by rewriting the if-statement. It would be nice if the port compiled without problems, even on an ancient system like this. :)

Suggested fix of Makefile, lines 67 and following, else ifneq:

    ifneq ($(filter $(UNAME_S),OpenBSD),)
   OS_LIBS =
    else
       ifneq ($(filter $(UNAME_S),FreeBSD),)
   OS_CFLAGS = -pthread
   OS_LIBS = -lpthread
       else
   OS_LIBS = -lpthread -ldl
       endif
    endif

[ryandesign (Ryan Carsten Schmidt)]

Rather than signing ourselves up for forever maintaining a patch to the Makefile, let's just use a compatible version of make. Fixed in r125531.