Opened 6 years ago

Closed 6 years ago

#44744 closed submission (fixed)

harminv 1.3.1 new port submission

Reported by: Yogesh.Sharma@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.1
Keywords: Cc:
Port: harminv

Description

Attached is a Portfile I created for harminv. Harminv is a library developed by MIT for solving the harmonic inversion problem.

Attachments (1)

Portfile (2.8 KB) - added by Yogesh.Sharma@… 6 years ago.
Added version of GPL to portfile

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Yogesh.Sharma@…

Cc: Yogesh.Sharma@… added

Cc Me!

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: Yogesh.Sharma@… removed
Keywords: science removed

Thanks.

What version(s) of the GPL apply? It should be indicated in the portfile.

Why does it need the macports-gcc-4.5 compiler? Instead, if the port will not compile with certain compilers, those compilers should be blacklisted, however ideally a port would be compilable with the default compiler.

Changed 6 years ago by Yogesh.Sharma@…

Attachment: Portfile added

Added version of GPL to portfile

comment:3 Changed 6 years ago by Yogesh.Sharma@…

I updated the Portfile to use the fortran recipe from PortfileRecipes#fortran and to include the version of the GPL license.

Last edited 6 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:4 Changed 6 years ago by Yogesh.Sharma@…

The reason I called out the gcc-4.5 compiler was the dependance on fortran. I updated the portfile to use the fortran recipe from https://trac.macports.org/wiki/PortfileRecipes#fortran

comment:5 Changed 6 years ago by Yogesh.Sharma@…

Is there anything else I need to do to get this port accepted?

comment:6 Changed 6 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

No. The port did violate the standard MacPorts filesystem hierarchy, because we expect manpages in $prefix/share/man, but that's easily fixed using the --mandir configure parameter.

Committed with this change in r125251, thanks for the submission.

For the record, if nobody picks up on your ticket, sending mail to the macports-dev list can get things going.

Note: See TracTickets for help on using tickets.