Opened 6 years ago

Last modified 6 years ago

#44835 new submission

[NEW] barnyard2

Reported by: jul_bsd@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: barnyard2

Description

dedicated spooler for Snort's unified2 binary output format

  • destroot ok

Attachments (1)

Portfile (5.7 KB) - added by jul_bsd@… 6 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Thanks. Some remarks:

We should not add the "mysql5" variant to new ports, since the mysql5 port is deprecated and has for a long time already been superseded by the mysql51 port; instead, we should work on phasing the mysql5 variant out of other ports.

There are newer versions of mariadb: mariadb-10.0 and mariadb-10.1. We should have variants for these as well, though I don't know what naming convention we should use ("-" is not a valid character in variant names). We should decide on this and be consistent about it, since this will affect many ports than just this one. Maybe you should bring it up on the mailing list and see if a consensus can be reached. We should also decide what default we want to use. Last time it was asked, I thought defaulting to the latest stable mariadb was a fine idea, but I don't remember if we finally decided on that.

The ./autogen.sh script regenerates the autotools files such as the configure script and the Makefiles. That's also what "use_autoconf yes" does. So in your current portfile, you're regenerating them twice. Usually you would set "use_autoconf yes", and if the project provides a script like ./autogen.sh to do that, then additionally set "autoconf.cmd ./autogen.sh" and use "depends_build-append port:autoconf port:automake port:libtool". MacPorts automatically adds those dependencies when you "use_autoconf yes" unless you override autoconf.cmd. I see that you added a dependency on port:autogen. Note that autogen is not a part of autotools and is not needed here. It is common for projects to include a script called "autogen.sh", but that's not related to the "autogen" port or executable.

In the ${name}-devel subport, you set "git.url https://github.com/firnsy/barnyard2.git"; you don't need to, since the github portgroup sets that for you. You also use "fetch.type git". Is that really necessary? It's preferable to use a tarball instead, which running github.setup will set up for you.

The distname, master_sites and livecheck overrides should not be necessary. Just set the correct tag prefix (the 4th parameter to github.setup):

github.setup        firnsy barnyard2 1.13 v2-

Changed 6 years ago by jul_bsd@…

Attachment: Portfile added
Note: See TracTickets for help on using tickets.