base: improve livecheck.type moddate

[pixilla (Bradley Giesbrecht)]

Currently livecheck.type moddate uses the Portfiles mtime for comparison to remotes mtime.

It would be useful to allow control of the comparison time. Attached is a patch to portlivecheck.tcl which enhances the livecheck.type moddate option to allow setting the comparison time, defaulting to current behavior.

There is also a new function "getmoddate" added to curl.c and a new livecheck.type option "moddate2" in portlivecheck.tcl which uses getmoddate to provide a more informative ui_msg.

The moddate2 option is added for easy comparison, not to add another option. I am proposing replacing the use of isnewer with getmoddate.

[pixilla (Bradley Giesbrecht)]

New features in the patches can be tested like this:

#moddate2:
version             20130325
livecheck.type      moddate2
livecheck.moddate   [clock scan ${version}]
livecheck.url       [lindex ${master_sites} 0]/[lindex ${distfiles} 0]

or the little changed moddate option:

#moddate:
version             20130325
livecheck.type      moddate
livecheck.moddate   [clock scan ${version}]
livecheck.url       [lindex ${master_sites} 0]/[lindex ${distfiles} 0]

[pixilla (Bradley Giesbrecht)]

Example output using the pear-install-phar port and moddate2:

$ port livecheck pear-install-phar
pear-install-phar seems to have been updated (port version: Mon Mar 25 00:00:00 PDT 2013, new version: Sun Aug 10 13:41:17 PDT 2014)

[mkae (Marko Käning)]

Cool stuff! This can be very useful in some cases!!! :-)

[raimue (Rainer Müller)]

As far as I see, this would be compatible to the existing moddate, so replacing it would be fine. There is only a small mistake in curl.c, where the declaration of function CurlModDateCmd does not match the definiton of CurlGetModDateCmd.

Otherwise, feel free to bring this to trunk/base with a corresponding ChangeLog entry.