Opened 10 years ago

Closed 10 years ago

#44984 closed update (fixed)

iftop 1.0pre4

Reported by: Schamschula (Marius Schamschula) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.1
Keywords: haspatch maintainer Cc: ryandesign (Ryan Carsten Schmidt)
Port: iftop

Description

iftop has been updated to version 1.0pre4. I have also replaced the lone md5 hash with the standard rmd160 and sha256 hashes. Detabed the Portfile. Assuming maintainership. (Portfile-iftop.pre4.diff)

Also did some more whitespace cleanup/reformatting (Portfile-iftop.whitespace.diff).

Attachments (2)

Portfile-iftop.pre4.diff (1.6 KB) - added by Schamschula (Marius Schamschula) 10 years ago.
Portfile-iftop.whitespace.diff (2.1 KB) - added by Schamschula (Marius Schamschula) 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

It looks like both patchfiles make whitespace adjustments. Could you give us one patchfile that makes whitespace adjustments, then a second patchfile that only makes functional changes, to be applied second? Then we can commit them in that order.

Changed 10 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-iftop.pre4.diff added

Changed 10 years ago by Schamschula (Marius Schamschula)

comment:2 Changed 10 years ago by Schamschula (Marius Schamschula)

Done. As recommended: the patch order is Portfile-iftop.whitespace.diff and then Portfile-iftop.pre4.diff.

comment:3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

I made your whitespace adjustments (and a few of my own, and added the modeline) in r125470.

comment:4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

In r86309 the port's version was erroneously set to "1.0" when in fact in installed version 1.0pre2. We should correct this when updating to 1.0pre4 and no longer misrepresent the version number.

Committed the update in r125471 with the above changes, and also changed the livecheck to match, and adjusted the homepage, and removed the now-unnecessary --mandir configure arg.

Note: See TracTickets for help on using tickets.