Opened 5 years ago

Closed 5 years ago

#45108 closed enhancement (fixed)

stunnel @5.03_0: add livecheck

Reported by: Schamschula (Marius Schamschula) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: stunnel

Description

I've added livecheck to stunnel.

Attachments (1)

Portfile-stunnel.diff (335 bytes) - added by Schamschula (Marius Schamschula) 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-stunnel.diff added

comment:1 Changed 5 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: newassigned
Summary: stunnel livecheckstunnel @5.03_0: add livecheck
Version: 2.3.1

This looks cleaner to me:

diff --git a/dports/security/stunnel/Portfile b/dports/security/stunnel/Portfile
index e2ef458..1d0789e 100644
--- a/dports/security/stunnel/Portfile
+++ b/dports/security/stunnel/Portfile
@@ -53,3 +53,7 @@ default_variants    +libwrap
 notes "
 A fake certificate has been installed as ${prefix}/etc/stunnel/stunnel.pem
 "
+
+livecheck.type      regex
+livecheck.url       http://www.stunnel.org/versions.html
+livecheck.regex     {Version (\d+(?:\.\d+)*) released}

comment:2 Changed 5 years ago by Schamschula (Marius Schamschula)

Larry,

I also considered the option of running the regex on http://www.stunnel.org/versions.html

but somewhere in the back of my mind I seem to remember the versions page as having been out of sync with the release version in the past.

Otherwise, I'm good with your patch, maybe replacing the homepage URL path:

diff --git a/dports/security/stunnel/Portfile b/dports/security/stunnel/Portfile
index e2ef458..1d0789e 100644
--- a/dports/security/stunnel/Portfile
+++ b/dports/security/stunnel/Portfile
@@ -53,3 +53,7 @@ default_variants    +libwrap
 notes "
 A fake certificate has been installed as ${prefix}/etc/stunnel/stunnel.pem
 "
+
+livecheck.type      regex
+livecheck.url       ${homepage}versions.html
+livecheck.regex     {Version (\d+(?:\.\d+)*) released}

comment:3 in reply to:  2 Changed 5 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: assignedclosed

Replying to mschamschula@…:

somewhere in the back of my mind I seem to remember the versions page as having been out of sync with the release version in the past.

Well, if that’s a possibility, we might as well just stick with your original. r125553

Note: See TracTickets for help on using tickets.