Opened 9 years ago
Closed 9 years ago
#45317 closed enhancement (fixed)
baloo: make baloo_file an "agent"
Reported by: | RJVB (René Bertin) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | NicosPavlov, mkae (Marko Käning) |
Port: | baloo |
Description
Tweaks the buildsystem to build baloo_file.app from port:baloo as an "agent" without presence in Dock, AppSwitcher or menubar.
This patchfile can be applied from an updated Portfile (not included).
Attachments (2)
Change History (12)
Changed 9 years ago by RJVB (René Bertin)
Attachment: | baloo_file-make-agent.patch added |
---|
Changed 9 years ago by RJVB (René Bertin)
Attachment: | baloo_file+indexer-make-agents.patch added |
---|
comment:1 Changed 9 years ago by RJVB (René Bertin)
The latest version of this patch also prevents baloo_file_extractor to behave as a background app (NB: this one is not built as a bundle).
In addition, it now sets the THROTTLE mode IO policy whenever on Linux baloo would call for lower IO priority.
comment:3 Changed 9 years ago by mkae (Marko Käning)
Hey, René, aren't these patches already in the current 4.13.3 port?!
I think this can be closed...
comment:4 Changed 9 years ago by RJVB (René Bertin)
No, I think they were committed to 4.14 (not the port, upstream!)
comment:5 Changed 9 years ago by mkae (Marko Käning)
No, I was trying to apply these patches definitely to
name baloo version 4.13.3
which results in
:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_Users_marko_WC_SVN_MacPorts_dports_kde_baloo/baloo/work/baloo-4.13.3" && /usr/bin/patch -p0' :debug:patch Executing command line: cd "/opt/local/var/macports/build/_Users_marko_WC_SVN_MacPorts_dports_kde_baloo/baloo/work/baloo-4.13.3" && /usr/bin/patch -p0 < '/Users/marko/WC/SVN/MacPorts/dports/kde/baloo/files/patch-baloo_file_indexer-make-agents.diff' :info:patch patching file src/file/CMakeLists.txt :info:patch Reversed (or previously applied) patch detected! Assume -R? [n] :info:patch Apply anyway? [n] :info:patch Skipping patch. :info:patch 1 out of 1 hunk ignored -- saving rejects to file src/file/CMakeLists.txt.rej :info:patch The next patch would create the file src/file/Info.plist.template, :info:patch which already exists! Assume -R? [n] :info:patch Apply anyway? [n] :info:patch Skipping patch. :info:patch 1 out of 1 hunk ignored -- saving rejects to file src/file/Info.plist.template.rej :info:patch patching file src/file/extractor/CMakeLists.txt :info:patch patching file src/file/extractor/main.cpp :info:patch patching file src/file/priority.cpp :info:patch patching file src/pim/agent/CMakeLists.txt :info:patch patching file src/pim/agent/Info.plist.template :info:patch Command failed: cd "/opt/local/var/macports/build/_Users_marko_WC_SVN_MacPorts_dports_kde_baloo/baloo/work/baloo-4.13.3" && /usr/bin/patch -p0 < '/Users/marko/WC/SVN/MacPorts/dports/kde/baloo/files/patch-baloo_file_indexer-make-agents.diff' :info:patch Exit code: 1 :error:patch org.macports.patch for port baloo returned: command execution failed :debug:patch Error code: CHILDSTATUS 68058 1 :debug:patch Backtrace: command execution failed
comment:6 Changed 9 years ago by RJVB (René Bertin)
So the issue is with src/file/CMakeLists.txt and the Info.plist template. Could you check the dates on those files in the distfiles tarball (in /opt/local/var/macports/distfiles/baloo)? Here the file is dated July 13th, and definitely doesn't have my patch in it.
I checked the RR (https://git.reviewboard.kde.org/r/120939/); no commit has been made in fact, unless Vishesh did some kind of backport to 4.13.3 ?!
comment:7 Changed 9 years ago by mkae (Marko Käning)
Resolution: | → fixed |
---|---|
Status: | new → closed |
I was erroneously using BOTH patches, instead of the up-to-date one! :-(
Fixed in r129342
comment:8 Changed 9 years ago by mkae (Marko Käning)
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Version: | 2.3.1 |
Too late I ran install on my machine showing me this now:
---> Staging baloo into destroot Error: org.macports.destroot for port baloo returned: error renaming "/opt/local/var/macports/build/_Users_marko_WC_SVN_MacPorts_dports_kde_baloo/baloo/work/destroot/opt/local/bin/baloo_file_extractor.app/Contents/MacOS/baloo_file_extractor": no such file or directory Please see the log file for port baloo for details: /opt/local/var/macports/logs/_Users_marko_WC_SVN_MacPorts_dports_kde_baloo/baloo/main.log To report a bug, follow the instructions in the guide: http://guide.macports.org/#project.tickets Error: Processing of port baloo failed
Also the buildbots fail, like for e.g. Mavericks :-(
comment:9 Changed 9 years ago by mkae (Marko Käning)
The outdated post-destroot phase had to be removed.
Done in r129345
comment:10 Changed 9 years ago by mkae (Marko Käning)
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
New version of the patch, now including akonadi_baloo_indexer.app and baloo_file_extractor