Opened 5 years ago

Closed 4 years ago

#45318 closed defect (fixed)

zsh @5.0.7_0: uses texi2html opportunistically

Reported by: Ionic (Mihai Moldovan) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: zsh

Description

zsh doesn't build without texi2html in trace mode. Add it.

Attachments (2)

zsh.diff (470 bytes) - added by Ionic (Mihai Moldovan) 5 years ago.
Add texi2html build dependency, otherwise zsh fails in trace mode.
main.log (184.9 KB) - added by Ionic (Mihai Moldovan) 5 years ago.
main.log to prove I'm not crazy

Download all attachments as: .zip

Change History (17)

Changed 5 years ago by Ionic (Mihai Moldovan)

Attachment: zsh.diff added

Add texi2html build dependency, otherwise zsh fails in trace mode.

comment:1 Changed 5 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… removed
Owner: changed from macports-tickets@… to larryv@…
Status: newassigned

What exactly does it use from texi2html? I don’t have that port installed, and the zsh build does not complain.

comment:2 Changed 5 years ago by Ionic (Mihai Moldovan)

Did you use -t to build?

It needs the (${prefix}/bin/)texi2html binary. Without that, the variable is substituted in Makefile templates with nothing, but still being called and the lines will be failing (up to the point of the make process segfaulting, interestingly.)

Last edited 5 years ago by Ionic (Mihai Moldovan) (previous) (diff)

Changed 5 years ago by Ionic (Mihai Moldovan)

Attachment: main.log added

main.log to prove I'm not crazy

comment:3 in reply to:  2 Changed 5 years ago by larryv (Lawrence Velázquez)

Replying to ionic@…:

Without that, the variable is substituted in Makefile templates with nothing, but still being called and the lines will be failing (up to the point of the make process segfaulting, interestingly.)

Okay, I see that segfault too, but only in trace mode; otherwise Make just ignores the error. Please open a new ticket about that.

comment:4 Changed 5 years ago by larryv (Lawrence Velázquez)

Keywords: maintainer removed
Summary: zsh: add texi2html build dependencyzsh @5.0.7_0: uses texi2html opportunistically
Version: 2.3.1

comment:5 Changed 5 years ago by larryv (Lawrence Velázquez)

I don't really know why the build is using texi2html at all; I don't see why the relevant makefile target is being evaluated.

comment:6 Changed 5 years ago by Ionic (Mihai Moldovan)

Portfile: destroot.target-append install.html install.info

comment:7 in reply to:  6 Changed 5 years ago by larryv (Lawrence Velázquez)

Yes, I know about that. I put it there.

I’m confused because the install.html target depends on the html target, which depends on zsh_toc.html, which is already provided by the documentation tarball.

comment:8 Changed 5 years ago by neverpanic (Clemens Lang)

You don't happen to have a crash report for the segfaulting shell, do you?

comment:9 Changed 5 years ago by neverpanic (Clemens Lang)

Er, obviously make is segfaulting, so that would be the crash report I'd be interested in.

comment:10 Changed 5 years ago by neverpanic (Clemens Lang)

comment:11 Changed 5 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:12 Changed 5 years ago by neverpanic (Clemens Lang)

The trace mode problem will be fixed in 2.3.2 due in a few days. r126894 merges the fix to the release branch.

comment:13 Changed 5 years ago by Ionic (Mihai Moldovan)

Resolution: fixed
Status: assignedclosed

comment:14 Changed 5 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: closedreopened

This is not fixed. zsh still uses texi2html opportunistically, which I don’t want.

Last edited 5 years ago by larryv (Lawrence Velázquez) (previous) (diff)

comment:15 Changed 4 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: reopenedclosed

Finally tracked this down! Only took two years.

r150774

Note: See TracTickets for help on using tickets.