Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#45482 closed defect (fixed)

rman: allow universal build and respect build architecture

Reported by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) Owned by: lomion@…
Priority: Normal Milestone:
Component: ports Version: 2.3.2
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: rman

Description

The following patch would allow rman to both build a universal binary and respect the build architecture preferences.

Attachments (1)

Portfile.diff (1.2 KB) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.diff added

comment:1 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:2 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

done r133692

comment:3 Changed 5 years ago by ryandesign (Ryan Schmidt)

It doesn't need to be that complicated. Simplified in r133714.

comment:4 Changed 5 years ago by ryandesign (Ryan Schmidt)

In fact, not only was the old way complicated, it didn't work correctly. The port did not declare a universal variant, yet the port responded to the universal variant, which meant that for me, since I have +universal in my variants.conf, the port installed universally even though the universal variant did not get recorded in the registry. My commit fixes this.

Note: See TracTickets for help on using tickets.