#45527 closed enhancement (fixed)
gmake: Add 'guile' variant
| Reported by: | nicholas.clark@… | Owned by: | stuartwesterman (Stuart Westerman) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | mf2k (Frank Schima), ryandesign (Ryan Carsten Schmidt) |
| Port: | gmake |
Description
As of version 4.0, GNU Make can be built with support for the Guile extension language. Can get get a variant option for installing Make with Guile?
I made a replacement Portfile, which is attached to this ticket.
Attachments (3)
Change History (18)
Changed 10 years ago by nicholas.clark@…
comment:1 follow-up: 2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added; make guile variant removed |
|---|---|
| Milestone: | MacPorts Future |
| Owner: | changed from macports-tickets@… to stuartwesterman@… |
| Summary: | Add 'guile' variant to GNU Make → gmake: Add 'guile' variant |
| Type: | update → enhancement |
Changed 10 years ago by nicholas.clark@…
| Attachment: | Portfile.patch added |
|---|
Unified diff file for the GNU Make Portfile
comment:2 Changed 10 years ago by nicholas.clark@…
comment:8 Changed 9 years ago by stuartwesterman (Stuart Westerman)
This works for me, why hasn't this been patched yet? I'm attaching the diff. Please update and close.
Changed 9 years ago by stuartwesterman (Stuart Westerman)
| Attachment: | add-guile-variant-gmake.diff added |
|---|
comment:9 Changed 9 years ago by mf2k (Frank Schima)
| Keywords: | maintainer added |
|---|---|
| Version: | 2.3.2 |
comment:10 Changed 9 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
We were waiting for maintainer (i.e. your) approval. r135940.
comment:11 Changed 9 years ago by mf2k (Frank Schima)
| Cc: | nicholas.clark@… removed |
|---|
comment:12 follow-up: 14 Changed 9 years ago by jmroot (Joshua Root)
| Cc: | mf2k@… added |
|---|
That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?)
comment:13 Changed 9 years ago by stuartwesterman (Stuart Westerman)
Oops! Sorry! I'm still learning. I'll try to make the appropriate changes tonight.
comment:14 Changed 9 years ago by mf2k (Frank Schima)
Replying to jmr@…:
That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?)
That's my fault. I meant to make it a smart quote to make the bbedit macports language work on the Portfile. I can fix it with Stuart's updated variant patch.
comment:15 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|
I've made the changes in r136051.
Please attach a unified diff instead.