Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#45527 closed enhancement (fixed)

gmake: Add 'guile' variant

Reported by: nicholas.clark@… Owned by: stuartwesterman (Stuart Westerman)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: mf2k (Frank Schima), ryandesign (Ryan Schmidt)
Port: gmake

Description

As of version 4.0, GNU Make can be built with support for the Guile extension language. Can get get a variant option for installing Make with Guile?

I made a replacement Portfile, which is attached to this ticket.

Attachments (3)

Portfile (1.5 KB) - added by nicholas.clark@… 6 years ago.
Portfile.patch (661 bytes) - added by nicholas.clark@… 6 years ago.
Unified diff file for the GNU Make Portfile
add-guile-variant-gmake.diff (630 bytes) - added by stuartwesterman (Stuart Westerman) 5 years ago.

Download all attachments as: .zip

Change History (18)

Changed 6 years ago by nicholas.clark@…

Attachment: Portfile added

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added; make guile variant removed
Milestone: MacPorts Future
Owner: changed from macports-tickets@… to stuartwesterman@…
Summary: Add 'guile' variant to GNU Makegmake: Add 'guile' variant
Type: updateenhancement

Please attach a unified diff instead.

Changed 6 years ago by nicholas.clark@…

Attachment: Portfile.patch added

Unified diff file for the GNU Make Portfile

comment:2 in reply to:  1 Changed 6 years ago by nicholas.clark@…

Replying to ryandesign@…:

Please attach a unified diff instead.

Done!

comment:3 Changed 6 years ago by nicholas.clark@…

Cc: nicholas.clark@… added

Cc Me!

comment:4 Changed 6 years ago by nicholas.clark@…

Cc: nicholas.clark@… removed

Cc Me!

comment:5 Changed 6 years ago by nicholas.clark@…

Cc: nicholas.clark@… added

Cc Me!

comment:6 Changed 6 years ago by nicholas.clark@…

Cc: nicholas.clark@… removed

Cc Me!

comment:7 Changed 6 years ago by nicholas.clark@…

Cc: nicholas.clark@… added

Cc Me!

comment:8 Changed 5 years ago by stuartwesterman (Stuart Westerman)

This works for me, why hasn't this been patched yet? I'm attaching the diff. Please update and close.

Changed 5 years ago by stuartwesterman (Stuart Westerman)

comment:9 Changed 5 years ago by mf2k (Frank Schima)

Keywords: maintainer added
Version: 2.3.2

comment:10 Changed 5 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

We were waiting for maintainer (i.e. your) approval. r135940.

comment:11 Changed 5 years ago by mf2k (Frank Schima)

Cc: nicholas.clark@… removed

comment:12 Changed 5 years ago by jmroot (Joshua Root)

Cc: mf2k@… added

That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?)

comment:13 Changed 5 years ago by stuartwesterman (Stuart Westerman)

Oops! Sorry! I'm still learning. I'll try to make the appropriate changes tonight.

comment:14 in reply to:  12 Changed 5 years ago by mf2k (Frank Schima)

Replying to jmr@…:

That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?)

That's my fault. I meant to make it a smart quote to make the bbedit macports language work on the Portfile. I can fix it with Stuart's updated variant patch.

comment:15 Changed 5 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

I've made the changes in r136051.

Note: See TracTickets for help on using tickets.