Opened 5 years ago

Last modified 2 years ago

#45619 assigned enhancement

gcc43, gcc44, gcc45, gcc47, gcc48, gcc49, gcc5: move libgcj pkgconfig file to default path

Reported by: anddam (Andrea D'Amore) Owned by: macports-tickets@…
Priority: Low Milestone:
Component: ports Version: 2.3.2
Keywords: Cc: larryv (Lawrence Velázquez), petrrr, ryandesign (Ryan Schmidt), cooljeanius (Eric Gallager)
Port: gcc43, gcc44, gcc45, gcc47, gcc48, gcc49, gcc5

Description

I'm attaching a patch to move libgcj-4.8.pc to $prefix/lib/pkgconfig.

The patch also adds a lib dependency on pkgconfig since there's a path: dependency on cloog-isl.pc, pkgconfig would be therefore better be present at build and runtime.

Attachments (1)

patch-port-gcc48.diff (1.2 KB) - added by anddam (Andrea D'Amore) 5 years ago.

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by anddam (Andrea D'Amore)

Attachment: patch-port-gcc48.diff added

comment:1 Changed 5 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… added

Cc Me!

comment:2 Changed 5 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:3 Changed 5 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

Committed r129167, maintainer timeout. Ticket closed.

comment:4 in reply to:  description ; Changed 5 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Replying to and.damore@…:

I'm attaching a patch to move libgcj-4.8.pc to $prefix/lib/pkgconfig.

As far as I can tell this affects gcc47 and later, not just gcc48. You should fix them all.

The patch also adds a lib dependency on pkgconfig since there's a path: dependency on cloog-isl.pc, pkgconfig would be therefore better be present at build and runtime.

That's not a reason to add a pkg-config dependency. Only add the dependency if pkg-config is actually used; I don't see any evidence that it is.

comment:5 in reply to:  4 ; Changed 5 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

As far as I can tell this affects gcc47 and later, not just gcc48. You should fix them all.

I can do gcc5 when I update it to the latest version shortly.

I'd like to switch this to use move instead of file rename, and to use ${major} instead of hardcoding the major version again.

comment:6 Changed 5 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: closedreopened

comment:7 Changed 5 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: reopenedclosed

Reverted r129176.

comment:8 in reply to:  5 Changed 5 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

I can do gcc5 when I update it to the latest version shortly.

r129208

comment:9 Changed 4 years ago by ryandesign (Ryan Schmidt)

Port: gcc43 gcc44 gcc45 gcc47 gcc49 gcc5 added
Resolution: fixed
Status: closedreopened
Summary: gcc48 @4.8.3_1 move libgcj pkgconfig file to default pathgcc43, gcc44, gcc45, gcc47, gcc48, gcc49, gcc5: move libgcj pkgconfig file to default path

gcc49 done in r138251. That leaves gcc47, gcc45, gcc44, gcc43. (gcc46 is not affected because for some reason it does not install gcj; see #31098.)

comment:10 Changed 4 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:11 Changed 2 years ago by kurthindenburg (Kurt Hindenburg)

Owner: changed from mww@… to macports-tickets@…
Status: reopenedassigned
Note: See TracTickets for help on using tickets.