Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#45679 closed update (fixed)

bsdowl: Update to v2.2.1

Reported by: michipili (Michael Grünewald) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: bsdowl

Description

This is a simple update to v2.2.1.

References:

Attachments (2)

patch-bsdowl.diff (1.3 KB) - added by michipili (Michael Grünewald) 3 years ago.
Update to v2.1.1
bsdowl-2.2.1-ryandesign.diff (1.2 KB) - added by ryandesign (Ryan Schmidt) 3 years ago.

Download all attachments as: .zip

Change History (15)

Changed 3 years ago by michipili (Michael Grünewald)

Update to v2.1.1

comment:1 Changed 3 years ago by mf2k (Frank Schima)

  • Keywords haspatch maintainer added
  • Port bsdowl added; devel/bsdowl removed
  • Version 2.3.2 deleted

comment:2 Changed 3 years ago by petrrr

  • Cc petr@… added

Cc Me!

comment:3 Changed 3 years ago by ryandesign (Ryan Schmidt)

The configure phase fails:

checking for gawk... gawk
checking for grep that handles long lines and -e... /opt/local/bin/grep
checking for a BSD-compatible install... /usr/bin/install -c
checking whether ln -s works... yes
checking for a thread-safe mkdir -p... /opt/local/bin/gmkdir -p
checking for a sed that does not truncate output... /opt/local/bin/gsed
checking for id that handles -g, -u and -n... id
checking for gm... yes
checking for bmake... no
configure: error: *** BSD Make not found.

The program the bsdmake port provides is called bsdmake not bmake.

comment:4 Changed 3 years ago by petrrr

  • Cc petr@… removed

Cc Me!

comment:5 Changed 3 years ago by ryandesign (Ryan Schmidt)

michipili, can you comment on the configure failure I reported above? Do you have a solution?

comment:6 follow-up: Changed 3 years ago by michipili (Michael Grünewald)

This is a missing dependency. The bsdowl port should depend on devel/bmake, for building and running. I can submit a patch in following days.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 3 years ago by michipili (Michael Grünewald)

This is is bigger problem than I thought.

First, as you ryandesign@… pointed it out, there is two BSD Make programs available in MacPorts:

  • bsdmake
  • bmake

These programs are very similar but distinct (at least, available versions are not compatible). The bsdowl software is actually compatible with our MacPorts for bmake but not bmake.

Dependencies are not an issue here, rather the build.type. Which value should I pick so that the make command used is bmake -r instead of bsdmake ?

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:8 in reply to: ↑ 7 Changed 3 years ago by larryv (Lawrence Velázquez)

Replying to michipili@…:

Dependencies are not an issue here, rather the build.type. Which value should I pick so that the make command used is bmake -r instead of bsdmake?

There is no value of build.type corresponding to bmake. You will probably need something like this (untested):

depends_build bin:bmake:bmake
build.cmd bmake
build.post_args -r

I’m just guessing that bmake accepts build targets as GNU Make does. You’ll probably have to tweak my example.

comment:9 follow-up: Changed 3 years ago by ryandesign (Ryan Schmidt)

  • Cc ryandesign@… added
  • Summary changed from devel/bsdowl: Update to v2.2.1 to bsdowl: Update to v2.2.1

If I install bmake, that satisfies the configure check. But given the existing "build.type bsdmake" in the Portfile, the port then builds using bsdmake, which seems to work fine. Are we certain bsdowl really requires bmake? If bsdmake will work, we should make that happen, e.g. by bypassing the configure check for bmake as in attachment:bsdowl-2.2.1-ryandesign.diff.

Changed 3 years ago by ryandesign (Ryan Schmidt)

comment:10 in reply to: ↑ 9 Changed 3 years ago by ryandesign (Ryan Schmidt)

  • Cc ryandesign@… removed
  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Replying to ryandesign@…:

Are we certain bsdowl really requires bmake?

I asked about this in the upstream issue tracker where the developer (who is also this ticket's reporter) explained that more bmake-specific functionality will be used in future versions of bsdowl, so it seems simplest for bsdowl in MacPorts to use bmake after all. We may want to add "build.type bmake" functionality to MacPorts base at some point. For now, since bsdowl will be the first port in MacPorts to use bmake, we can do it manually as Larry suggested. I'll do that and commit the update.

comment:11 Changed 3 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:12 follow-up: Changed 3 years ago by ryandesign (Ryan Schmidt)

And then I realized one of the changes in 2.2.1 is:

#41 Command mp2png is now implemented using GraphicsMagick

So GraphicsMagick is a runtime dependency as well, and not just a build dependency. So that makes it a library dependency. Changed in r129879.

comment:13 in reply to: ↑ 12 Changed 3 years ago by michipili (Michael Grünewald)

Changed in r129879.

Thank you for your help!

Note: See TracTickets for help on using tickets.