Opened 6 years ago

Last modified 21 months ago

#45823 new submission

[NEW]: rb21-fontcustom with dependent rb21 ports

Reported by: robertoschwald@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: chrstphrchvz (Christopher Chavez)
Port: rb21-celluloid rb21-ffi rb21-fontcustom rb21-hitimes rb21-listen rb21-rb-fsevent rb21-rb-inotify rb21-thor rb21-timers

Description (last modified by mf2k (Frank Schima))

New Port rb21-fontcustom with this new rb21- dependent ports:

rb21-celluloid
rb21-ffi
rb21-fontcustom
rb21-hitimes
rb21-listen
rb21-rb-fsevent
rb21-rb-inotify
rb21-thor
rb21-timers

Note: This port needs Port eot-utils, which I submitted in ticket #45814

Lint report:

port lint --nitpick rb21*
--->  Verifying Portfile for rb21-celluloid
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-ffi
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-fontcustom
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-hitimes
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-listen
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-rb-fsevent
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-rb-inotify
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-thor
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for rb21-timers
--->  0 errors and 0 warnings found.

Attachments (10)

2014-11-08_rb21-fontcustom_with_rb21-dependencies.tar.gz (2.7 KB) - added by robertoschwald@… 6 years ago.
rb21-fontconfig port and dependent new rb21 ports
Portfile (1.7 KB) - added by robertoschwald@… 6 years ago.
rb21-fontcustom Portfile
Portfile.2 (691 bytes) - added by robertoschwald@… 6 years ago.
rb21-timers
Portfile.3 (716 bytes) - added by robertoschwald@… 6 years ago.
rb21-thor Portfile
Portfile.4 (702 bytes) - added by robertoschwald@… 6 years ago.
rb21-rb-inotify
Portfile.5 (711 bytes) - added by robertoschwald@… 6 years ago.
rb21-rb-fsevent Portfile
Portfile.6 (748 bytes) - added by robertoschwald@… 6 years ago.
rb21-listen Portfile
Portfile.7 (1.1 KB) - added by robertoschwald@… 6 years ago.
rb21-hitimes Portfile
Portfile.8 (796 bytes) - added by robertoschwald@… 6 years ago.
rb21-ffi Portfile
Portfile.9 (870 bytes) - added by robertoschwald@… 6 years ago.
rb21-celluloid Portfile

Download all attachments as: .zip

Change History (20)

Changed 6 years ago by robertoschwald@…

rb21-fontconfig port and dependent new rb21 ports

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)
Version: 2.3.2

In the future, please use WikiFormatting.

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Port: rb21-celluloid rb21-ffi rb21-hitimes rb21-listen rb21-rb-fsevent rb21-rb-inotify rb21-thor rb21-timers added

comment:3 Changed 6 years ago by mf2k (Frank Schima)

It is generally better to submit one port per ticket.

comment:4 Changed 6 years ago by robertoschwald@…

I've explicitely asked on IRC and was told that it is ok to send all in one: http://echelog.com/logs/browse/macports/1415401200 [12:46:56]

comment:5 Changed 6 years ago by mf2k (Frank Schima)

That link does not work for me. Nevertheless, while you certainly can do it, I think it makes it less likely to get committed, at least by me.

Last edited 6 years ago by mf2k (Frank Schima) (previous) (diff)

comment:6 Changed 6 years ago by robertoschwald@…

ok. Then I know for the future. Should I open submission tickets per port for them?

comment:7 Changed 6 years ago by mf2k (Frank Schima)

It's up to you. Maybe the person on IRC is willing to look at this ticket? Otherwise, from my point of view, it would at least be better if you individually attach each Portfile to this ticket so they can be viewed and commented on without downloading a tarball.

Changed 6 years ago by robertoschwald@…

Attachment: Portfile added

rb21-fontcustom Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.2 added

rb21-timers

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.3 added

rb21-thor Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.4 added

rb21-rb-inotify

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.5 added

rb21-rb-fsevent Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.6 added

rb21-listen Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.7 added

rb21-hitimes Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.8 added

rb21-ffi Portfile

Changed 6 years ago by robertoschwald@…

Attachment: Portfile.9 added

rb21-celluloid Portfile

comment:8 Changed 6 years ago by mf2k (Frank Schima)

Thanks. For all of the ports:

For rb21-fontcustom - same as above plus:

  • Remove the python26 variant since all pythons except 2.7 and 3.4 are being phased out of Macports.
  • For the python27 variant:
    • The description does not describe what is happening when this variant is selected. Something like "Build with python 2.7 fontforge bindings" would be better if that is what is happening.
    • You must do more than simply add a dependency on fontforge +python27, What happens if the user has fontforge +python27 installed but does not select this variant? Usually a configure argument(s) should be set to use python or not.
  • Change "depends_lib" to "depends_lib-append" to not overwrite the portgroup dependencies. In this case, you should remove the ruby21 dependency since the ruby portgroup will add that for you.

comment:9 Changed 21 months ago by chrstphrchvz (Christopher Chavez)

Ruby 2.1 has been EOL since 2017. Are these ports still desirable for newer Ruby versions?

comment:10 Changed 21 months ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added
Note: See TracTickets for help on using tickets.