Opened 6 years ago

Closed 6 years ago

#45974 closed defect (fixed)

xml2rfc 1.36 Fails to build due to upstream URL change

Reported by: stevecheckoway (Stephen Checkoway) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: xml2rfc

Description

make fails due to upstream's URL changing. The attached patches fix the build with a minimum of changes.

The old URL does return an HTTP 301 status but in one case, the redirect isn't followed so the example.xml.diff updates the URL to the new one.

Attachments (2)

patch-example.xml.diff (412 bytes) - added by stevecheckoway (Stephen Checkoway) 6 years ago.
Portfile-xml2rfc.diff (382 bytes) - added by stevecheckoway (Stephen Checkoway) 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by stevecheckoway (Stephen Checkoway)

Attachment: patch-example.xml.diff added

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Keywords: haspatch added

Thanks!

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Is this a build failure only? If so, then the revision should not be increased. Only increase the revision if users who already have the port installed would benefit from rebuilding it.

comment:3 in reply to:  2 Changed 6 years ago by stevecheckoway (Stephen Checkoway)

Replying to ryandesign@…:

Is this a build failure only? If so, then the revision should not be increased. Only increase the revision if users who already have the port installed would benefit from rebuilding it.

I believe it is a build failure only. I wasn't sure if that needed a revision bump or not. I'll upload a new Portfile patch.

Changed 6 years ago by stevecheckoway (Stephen Checkoway)

Attachment: Portfile-xml2rfc.diff added

comment:4 Changed 6 years ago by software@…

I was just about to report this issue. The supplied patch works for me. Thanks for this fix!

comment:5 Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

thanks r128579

Note: See TracTickets for help on using tickets.