Opened 5 years ago

Closed 3 years ago

#46107 closed defect (fixed)

salt @2014.1.13 no destroot found - failed copying minion conifg file

Reported by: urs.rau@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: macports.org@…, markus.falb@…, hahn.seb@…, neverpanic (Clemens Lang), macports@…
Port: salt

Description (last modified by mf2k (Frank Schima))

When I run on my Yosemite 10.10.1 using cmd line tools 6.1.1 GM the sequence

port uninstall salt 
port clean salt 
port install salt

I get an error about it not being able to copy the minion conf file (see attached log) But if I do a

port uninstall salt 
port clean salt 
port install -v -d -k salt

I get an error saying that it can't find the destroot

In both cases I get no files installed inot /opt except for the minion.plist file.

Attachments (2)

main.log (43.2 KB) - added by urs.rau@… 5 years ago.
error log
saltPortfilePatch (675 bytes) - added by hahn.seb@… 5 years ago.

Download all attachments as: .zip

Change History (23)

Changed 5 years ago by urs.rau@…

Attachment: main.log added

error log

comment:1 Changed 5 years ago by urs.rau@…

Cc: urs.rau@… added

Cc Me!

comment:2 Changed 5 years ago by mf2k (Frank Schima)

Cc: cr@… urs.rau@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to cr@…

In the future, please use WikiFormatting. As reporter, you do not need to Cc yourself.

Error is:

:debug:activate Backtrace: error copying "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_salt/salt/work/v2014.1.13/conf/minion": no such file or directory

comment:3 Changed 5 years ago by robert@…

I'm having the same problem. If you look at the ports files, when the names changed to salt-2014.1.13 from salt-0.17.1 on 11/20, the file lost the salt contents and just contains the plist files. The size went to 2.8K from 1.5M.

comment:4 Changed 5 years ago by cr@…

OK, I'll look into this.

comment:5 Changed 5 years ago by macports.org@…

Having the same problem. tail of log file is below. Cc me please.

:debug:activate activating file: /opt/local/etc/LaunchDaemons/org.macports.salt-minion/org.macports.salt-minion.plist
:notice:activate 
:notice:activate This port configures a LaunchItem for salt-minion.
:notice:activate 
:notice:activate It also installs LaunchItems for the salt-master and the salt-syndic.
:notice:activate 
:notice:activate To start the salt-master via launchd, run
:notice:activate     
:notice:activate sudo launchctl load -w /Library/LaunchDaemons/com.saltstack.salt.master.plist
:notice:activate 
:notice:activate To start the salt-syndic via launchd, run
:notice:activate 
:notice:activate sudo launchctl load -w /Library/LaunchDaemons/com.saltstack.salt.syndic.plist
:notice:activate 
:notice:activate To disable launchd management for the master or syndic, run the appropriate
:notice:activate unload command:
:notice:activate 
:notice:activate sudo launchctl unload -w /Library/LaunchDaemons/com.saltstack.salt.master.plist
:notice:activate or
:notice:activate sudo launchctl unload -w /Library/LaunchDaemons/com.saltstack.salt.syndic.plist
:notice:activate 
:notice:activate 
:debug:activate Executing proc-post-org.macports.activate-activate-0
:error:activate org.macports.activate for port salt returned: error copying "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_salt/salt/work/v2014.1.13/conf/minion": no such file or directory
:debug:activate Error code: NONE
:debug:activate Backtrace: error copying "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_salt/salt/work/v2014.1.13/conf/minion": no such file or directory
    while executing
"proc-post-org.macports.activate-activate-0 org.macports.activate"
    ("eval" body line 1)
    invoked from within
"eval $post $targetname"
:info:activate Warning: targets not executed for salt: org.macports.activate
:notice:activate Please see the log file for port salt for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_sysutils_salt/salt/main.log

comment:6 in reply to:  5 ; Changed 5 years ago by larryv (Lawrence Velázquez)

Cc: macports.org@… added

Replying to macports.org@…:

Cc me please.

I’ve added you to the Cc list, but you should Cc yourself in the future by clicking the Cc button.

comment:7 in reply to:  6 Changed 5 years ago by macports.org@…

Replying to larryv@…:

Replying to macports.org@…:

Cc me please.

I’ve added you to the Cc list, but you should Cc yourself in the future by clicking the Cc button.

Thanks, and thanks for clarifying.

comment:8 Changed 5 years ago by markus.falb@…

Cc: markus.falb@… added

Cc Me!

comment:9 Changed 5 years ago by hahn.seb@…

Cc: hahn.seb@… added

Cc Me!

comment:10 Changed 5 years ago by hahn.seb@…

Anything we can do to help track this down?

comment:11 Changed 5 years ago by jmroot (Joshua Root)

The portfile currently does this:

destroot {

    if ![file exists ${destroot}/Library/LaunchDaemons] {
        file mkdir ${destroot}/Library/LaunchDaemons
    }
    copy ${worksrcpath}/pkg/darwin/com.saltstack.salt.master.plist ${destroot}/Library/LaunchDaemons
    copy ${worksrcpath}/pkg/darwin/com.saltstack.salt.syndic.plist ${destroot}/Library/LaunchDaemons

}

You probably want a post-destroot block there, not a destroot phase that does nothing but install those two plists.

comment:12 Changed 5 years ago by hahn.seb@…

The install goes through here with that change but there still aren't any binaries installed

comment:13 Changed 5 years ago by hahn.seb@…

Using port install -s -v salt, the port installed and I had the binaries put in place correctly, too after changing the destroot to a post-destroot in the portfile.

But something still seems busted. The version is supposed to be 2014.1.13, but salt --version reports 2014.1.0 (Hydrogen) as the version.

Changed 5 years ago by hahn.seb@…

Attachment: saltPortfilePatch added

comment:14 Changed 5 years ago by hahn.seb@…

Attached a patch which fixes this in my testing.

comment:15 Changed 5 years ago by neverpanic (Clemens Lang)

Cc: cal@… added

comment:16 Changed 5 years ago by hahn.seb@…

This should probably have a haspatch keyword

comment:17 Changed 5 years ago by neverpanic (Clemens Lang)

Keywords: haspatch added

Sorry for the delay, please don't hesitate to bug me repeatedly about this change.

comment:18 Changed 4 years ago by neverpanic (Clemens Lang)

Committed in r133159, thanks for the patch. Maintainer timeout.

comment:19 Changed 4 years ago by macports@…

Cc: macports@… added

Cc Me!

comment:20 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Owner: changed from cr@… to macports-tickets@…

comment:21 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

I'm assuming comment:18 means this is fixed.

Note: See TracTickets for help on using tickets.