clang-3.6 @3.6-r223943 -arm_runtime: reinplace produces makefile syntax error

[ryandesign (Ryan Carsten Schmidt)]

There seems to be an errant close-parenthesis somewhere:

:info:build   MKDIR:     /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins
:info:build mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins > /dev/null
:info:build   MKDIR:     /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)
:info:build mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/) > /dev/null
:info:build /bin/sh: -c: line 0: syntax error near unexpected token `)'
:info:build /bin/sh: -c: line 0: syntax error near unexpected token `)'
:info:build /bin/sh: -c: line 0: `mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/) > /dev/null'
:info:build /bin/sh: -c: line 0: `mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins > /dev/null'
:info:build make[4]: *** [/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/.dir] Error 2
:info:build make[4]: *** Waiting for unfinished jobs....
:info:build make[4]: *** [/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins/.dir] Error 2
:info:build make[4]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/projects/compiler-rt'
:info:build make[3]: *** [BuildRuntimeLibraries] Error 2
:info:build rm /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/Release+Debug+Asserts/lib/clang/3.6.0/lib/macho_embedded/.dir /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/Release+Debug+Asserts/lib/clang/3.6.0/lib/darwin/.dir
:info:build make[3]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt'
:info:build make[2]: *** [compiler-rt/.makeall] Error 2
:info:build make[2]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime'
:info:build make[1]: *** [all] Error 1
:info:build make[1]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang'
:info:build make: *** [all] Error 1

[larryv (Lawrence Velázquez)]

Cc Me!

[larryv (Lawrence Velázquez)]

Has duplicate #46201.

[h.rayflood@…]

this error may caused by ​http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?r1=221622&r2=221656

[h.rayflood@…]

Replying to h.rayflood@…:

this error may caused by ​http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?r1=221622&r2=221656

oh, sorry. I misunderstood...

[larryv (Lawrence Velázquez)]

I couldn’t reproduce this on Lion. Initially I was running into a different problem in the same part of the build; after fixing that with r129438, the build completed successfully.

Does that change fix this issue also?

[h.rayflood@…]

no, r129438 cannot fix this issue.

info:

my filesystem:
hfs+, journaling, case-sensitive

$ make --version
GNU Make 3.81

$ ./port variants clang-3.6
clang-3.6 has the variants:
[+]analyzer: Install clang static analyzer
(-)arm_runtime: Build and install the arm runtime for iOS development (requires iOS SDK)
(+)assertions: Enable assertions for error detection (has performance impacts, especially on JIT)
universal: Build for multiple architectures

$ cat ../etc/macports/variants.conf
+perl5_8 +assertions -arm_runtime

[larryv (Lawrence Velázquez)]

Replying to h.rayflood@…:

no, r129438 cannot fix this issue.

“Cannot”? Do you mean “did not”? Did you actually run selfupdate and try building again? If so, please attach a new complete log.

[h.rayflood@…]

I attached a log.

[larryv (Lawrence Velázquez)]

Okay, so both you and Ryan are disabling the arm_runtime variant. I suspect that this bit of the portfile is not behaving as expected:

post-patch {
    if {${subport} eq "clang-${llvm_version}"} {
        # http://trac.macports.org/ticket/33272
        if {![variant_isset arm_runtime]} {
            reinplace {/^SubDirs/ s/arm//} ${worksrcpath}/projects/compiler-rt/lib/Makefile.mk
            reinplace {/^UniversalArchs/ s/arm[^ )]* *//g} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk

            reinplace {/cc_kext_ios5/ s/^/#/} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk
            reinplace {s/cc_kext_ios5.a//} ${worksrcpath}/tools/clang/runtime/compiler-rt/Makefile
        }

[larryv (Lawrence Velázquez)]

Ugh, this is why I hate reinplaces.

[h.rayflood@…]

Replying to larryv@…:

Okay, so both you and Ryan are disabling the arm_runtime variant. I suspect that this bit of the portfile is not behaving as expected:

post-patch {
    if {${subport} eq "clang-${llvm_version}"} {
        # http://trac.macports.org/ticket/33272
        if {![variant_isset arm_runtime]} {
            reinplace {/^SubDirs/ s/arm//} ${worksrcpath}/projects/compiler-rt/lib/Makefile.mk
            reinplace {/^UniversalArchs/ s/arm[^ )]* *//g} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk

            reinplace {/cc_kext_ios5/ s/^/#/} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk
            reinplace {s/cc_kext_ios5.a//} ${worksrcpath}/tools/clang/runtime/compiler-rt/Makefile
        }

I attached a patch. thanks for your advise.
this error occurred from ​http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?r1=221610&r2=221621

[larryv (Lawrence Velázquez)]

Thanks, but this is just papering over the actual problem. I’m going to get rid of the substitutions altogether.

[ryandesign (Ryan Carsten Schmidt)]

Replying to larryv@…:

Okay, so both you and Ryan are disabling the arm_runtime variant.

I'm just using the default variants. Looks like the arm_runtime variant is default with Xcode 4 and later. On Snow Leopard I have Xcode 3.2.6.

[larryv (Lawrence Velázquez)]

Okay, I reproduced the -arm_runtime failure and fixed it with r129516. Please verify.

[h.rayflood@…]

build succeeded. thanks.

[larryv (Lawrence Velázquez)]

The Snow Leopard buildslave built it successfully also.