Opened 12 years ago
Closed 11 years ago
#46241 closed update (fixed)
git-flow update: bump subport git-flow-avh v1.7.0 -> v1.8.0
| Reported by: | gorticus (Jason Mitchell) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | haspatch maintainer | Cc: | kurthindenburg (Kurt Hindenburg) |
| Port: | git-flow-avh |
Description
Gitflow AVH edition v1.8.0 was released 2014-10-01. Update Portfile with new release version.
Attachments (1)
Change History (8)
comment:1 follow-up: 3 Changed 12 years ago by mf2k (Frank Schima)
comment:2 follow-up: 4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Why doesn't this subport fetch from a distfile? The other three subports use git submodule update --init, which is a valid reason to use fetch.type git, but git-flow-avh doesn't.
Changed 12 years ago by gorticus (Jason Mitchell)
| Attachment: | patch-Portfile-gitflow-avh.txt added |
|---|
Portfile patch, addresses comment:1
comment:3 Changed 12 years ago by gorticus (Jason Mitchell)
Replying to mf2k@…:
Thanks. The
revisionline should be deleted because it starts at 0 when increasing the version and that is the default value.
Removed, patch updated.
comment:4 Changed 12 years ago by gorticus (Jason Mitchell)
Replying to ryandesign@…:
Why doesn't this subport fetch from a distfile? The other three subports use
git submodule update --init, which is a valid reason to usefetch.type git, but git-flow-avh doesn't.
Combination limited time and ignorance on my part. A quick peek at github-1.0.tcl showed no github.tarball_from option matched the github.master_sites results in the switch switch for the archive focused URL in gitflow AVH's release page. Since github-1.0.tcl specifically mentions github.master_sites expects a simple string and not a list, I fumbled to build a recipe for the right tarball_from. The clone worked, so I stuck with it.
comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Correct, the github portgroup does not have an option for archive URLs yet, because nobody has yet come up with a reason to do so. See #40518.
comment:7 Changed 11 years ago by kurthindenburg (Kurt Hindenburg)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
done and I also changed to use distfiles r137258

Thanks. The
revisionline should be deleted because it starts at 0 when increasing the version and that is the default value.