Opened 6 years ago

Last modified 2 years ago

#46247 assigned defect

cpan2port: fix dependency checking

Reported by: mojca (Mojca Miklavec) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg), drkp (Dan Ports), ryandesign (Ryan Schmidt), dbevans (David B. Evans)
Port: cpan2port

Description

Here is part of META.yml from Catalyst::Plugin::Session::Store::Delegate (version 0.06)

build_requires:
  ExtUtils::MakeMaker: 6.42
  Test::More: 0
  Test::use::ok: 0
configure_requires:
  ExtUtils::MakeMaker: 6.42
requires:
  Catalyst::Plugin::Session: 0.27
  MRO::Compat: 0
  Moose: 0
  MooseX::Emulate::Class::Accessor::Fast: 0
  namespace::clean: 0

It generates the following list:

    depends_lib-append \
                    port:p${perl5.major}-catalyst-plugin-session \
                    port:p${perl5.major}-moose \
                    port:p${perl5.major}-moosex-emulate-class-accessor-fast \
                    port:p${perl5.major}-mro-compat \
                    port:p${perl5.major}-namespace-clean

In particular the dependency Test::use::ok is missing. I don't understand the code well enough yet to be able to fix it though.

Can someone please help me?

See also my (wrong) bug report and answer at:

Change History (7)

comment:1 Changed 6 years ago by mojca (Mojca Miklavec)

Another weird thing is that

cpan2port -t Sysadm::Install

suggest

port:p${perl5.major}-termreadkey

but we only have

port:p${perl5.major}-term-readkey

comment:2 in reply to:  description Changed 6 years ago by dbevans (David B. Evans)

Cc: devans@… added
Owner: changed from macports-tickets@… to egall@…
Port: cpan2port added

In particular the dependency Test::use::ok is missing. I don't understand the code well enough yet to be able to fix it though.

Note that Test::use::ok (and Test::Tester) are provided by Test::Simple as of version 1.001010. See Test-Simple-1.001014/Changes.

However, the version of Test::Simple in perl5.20 core is only 1.001002. Therefore, a dependency on p5-test-simple is called for to supply this module.

Last edited 6 years ago by dbevans (David B. Evans) (previous) (diff)

comment:3 Changed 6 years ago by cooljeanius (Eric Gallager)

Just wondering, why is this assigned to me? I only maintain the Portfile for cpan2port; I don't maintain the actual script itself...

comment:4 in reply to:  3 ; Changed 6 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

Just wondering, why is this assigned to me? I only maintain the Portfile for cpan2port

Uh, yeah. This is what happens when you’re a port maintainer. You get assigned tickets.

comment:5 in reply to:  4 Changed 6 years ago by cooljeanius (Eric Gallager)

Replying to larryv@…:

Replying to egall@…:

Just wondering, why is this assigned to me? I only maintain the Portfile for cpan2port

Uh, yeah. This is what happens when you’re a port maintainer. You get assigned tickets.

But this isn't about the port, it's about the script itself, which lives in contrib. I'd consider this an upstream issue, except that MacPorts itself is the upstream here...

comment:6 Changed 2 years ago by mf2k (Frank Schima)

Cc: mf2k removed
Owner: cooljeanius deleted
Status: newassigned

comment:7 Changed 2 years ago by mf2k (Frank Schima)

See #56907.

Note: See TracTickets for help on using tickets.