Opened 9 years ago

Closed 9 years ago

#46386 closed update (fixed)

updated port: adns 1.5.0

Reported by: roederja Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: adns

Description

Straight forward update to version 1.5

Attachments (2)

Portfile.diff (1.1 KB) - added by roederja 9 years ago.
Portfile-adns.diff (1.4 KB) - added by Schamschula (Marius Schamschula) 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by roederja

Attachment: Portfile.diff added

comment:1 Changed 9 years ago by roederja

Keywords: haspatch added
Owner: changed from toby to toby@…

comment:2 Changed 9 years ago by tobypeterson

WTF, GPLv3. Probably worth making a new port. Or just never updating.

comment:3 Changed 9 years ago by tobypeterson

Owner: changed from toby@… to macports-tickets@…

I've dropped maintainership of the port - I do not maintain GPLv3 software. If anyone else would like to pick it up and handle this update, go for it.

comment:4 Changed 9 years ago by Schamschula (Marius Schamschula)

Updating the patch file to reflect assuming maintainership of the port. wireshark +adns is a dependent, so I need this myself.

Changed 9 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-adns.diff added

comment:5 Changed 9 years ago by Schamschula (Marius Schamschula)

Fixed an issue where the linker was trying to link against the installed libadns rather the one being built.

comment:6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Jann committed his patch in r132870 but it does not build for me, perhaps because of the issue Marius addressed in his patch (though I would prefer to see the issue fixed in the source, rather than by tweaking LDFLAGS in the portfile).

comment:7 Changed 9 years ago by roederja

Oh, you are probably right. Will have a look at it tonight. Feel free to revert in the meantime - but I assume the old version had the same problem.

comment:8 Changed 9 years ago by mp@…

I couldn't upgrade either, but adding

  configure.ldflags "-L../src -L${prefix}/lib"

from #attachment:Portfile-adns.diff solved it.

Got the following error:

:info:build In file included from adh-main.c:28:
:info:build In file included from ./adnshost.h:48:
:info:build ../src/dlist.h:30:9: warning: 'LIST_INIT' macro redefined
:info:build #define LIST_INIT(list) ((list).head= (list).tail= 0)
:info:build         ^
:info:build /usr/include/sys/queue.h:478:9: note: previous definition is here

(On 10.9.5)

Last edited 9 years ago by mp@… (previous) (diff)

comment:9 Changed 9 years ago by roederja

Resolution: fixed
Status: newclosed

Added the patch. But on my system it doesn't make a difference.

Note: See TracTickets for help on using tickets.