Opened 6 years ago

Closed 6 months ago

#46563 closed defect (fixed)

sslh 1.16 doesn't build on 10.6

Reported by: spam@… Owned by: amake (Aaron Madlon-Kay)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: snowleopard leopard tiger Cc: ryandesign (Ryan Schmidt)
Port: sslh

Description

sslh switched to memmem from strstr which doesn't exist on 10.6. It would be nice to have this updated, either to DEFINE memmem(W,X,Y,Z) = strstr(W,Y) when memmem isn't available, or to link to glibc as the threads on sslh spoke of.

This is the change that introduced memmem: https://github.com/yrutschle/sslh/commit/708c3b0177532044b74fc3581fb25c6734831e9b

This is the start of the discussion on memmem, although it spans months, so you may have to work to see more of the convo: http://rutschle.net/pipermail/sslh/2014-March/000501.html

Change History (6)

comment:1 Changed 6 years ago by spam@…

Cc: spam@… added

Cc Me!

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: spam@… removed
Keywords: snowleopard leopard tiger added
Owner: changed from macports-tickets@… to macports@…

It would typically be the responsibility of the developer of sslh to make any such change. Once they've done that and released a new version including that change, we can update the port in MacPorts to that version.

comment:3 Changed 6 years ago by amake (Aaron Madlon-Kay)

You might as well raise this as an issue on GitHub.

comment:4 Changed 6 years ago by spam@…

Being that it has already been discussed by the maintainer on the mailing list, I think it would be redundant to pester them more.

comment:5 Changed 6 months ago by ryandesign (Ryan Schmidt)

Cc: ryandesign added
Owner: changed from macports@… to amake
Status: newassigned

I added the legacysupport portgroup to this port in [24c8487350c02c00ea107714ef4802cd6a26083e/macports-ports] but that didn't work (or doesn't work anymore) because this port doesn't pass MacPorts CFLAGS/LDFLAGS to the build system -- which it should be fixed to do.

I have filed an upstream issue here: https://github.com/yrutschle/sslh/issues/278

comment:6 Changed 6 months ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

In 8e0f1dd084fe4a862b2dae57caf5096c7b3e9efc/macports-ports (master):

sslh: Pass MacPorts CFLAGS/LDFLAGS to the Makefile

Use the makefile 1.0 portgroup so that the CFLAGS and LDFLAGS MacPorts
specifies are used by the build.

Closes: #46563

While we're at it, upgrade to the legacysupport 1.1 portgroup.

Note: See TracTickets for help on using tickets.