Opened 4 years ago

Closed 4 years ago

#46743 closed submission (fixed)

vcs_blackbox @1.20150203 New contribution

Reported by: tal@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mkae (Marko Käning), macports@…, mojca (Mojca Miklavec)
Port: vcs_blackbox

Description (last modified by mojca (Mojca Miklavec))

This is a request to add a new port blackbox to MacPorts:

Description:

Storing secrets such as passwords, certificates and private keys in Git/Mercurial/SubVersion is dangerous. Blackbox makes it easy to store secrets safely using GPG encryption. They can be easily decrypted for editing or use in production.

Attachments (2)

Portfile (1.5 KB) - added by tal@… 4 years ago.
vcs_blackbox.Portfile (1.1 KB) - added by mojca (Mojca Miklavec) 4 years ago.
suggestions for improving the Portfile for blackbox

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by tal@…

Attachment: Portfile added

comment:1 Changed 4 years ago by tal@…

Cc: tal@… added

Cc Me!

comment:2 Changed 4 years ago by tal@…

This is my first time submitting to Macports. I haven't heard back from anyone about this new submission. Is there something I need to do?

comment:3 Changed 4 years ago by mkae (Marko Käning)

Cc: tal@… removed
Version: 2.3.3

You don't need to enter yourself into CC, as you're already the one who opened the ticket.

comment:4 Changed 4 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:5 Changed 4 years ago by macports@…

Cc: macports@… added

Cc Me!

comment:6 Changed 4 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:7 Changed 4 years ago by mojca (Mojca Miklavec)

These lines use a slightly "unnatural" approach:

use_configure       no
build               {}

destroot {
  system "cd ${worksrcpath} && make packages-macports DESTDIR=${destroot}/${prefix}"
}

It would make slightly more sense to adapt variables, for example change destroot.target to packages-macports and destroot.destdir to DESTDIR=${destroot}/${prefix}" and let MacPorts work out the rest of the "magic"

Just curious: in what respect is MacPorts special, so that you need a special target in Makefile to handle MacPorts? Why doesn't make install DESTDIR=${destroot}[/${prefix}] work?

Related to the comments in your Portfile. Try to delete (or comment out) the line with checksums and run

port -v extract vcs_blackbox

This will give you the checksums you need without additional effort. It's a good practice to include both rmd160 and sha256.

Last edited 4 years ago by mojca (Mojca Miklavec) (previous) (diff)

Changed 4 years ago by mojca (Mojca Miklavec)

Attachment: vcs_blackbox.Portfile added

suggestions for improving the Portfile for blackbox

comment:8 Changed 4 years ago by mojca (Mojca Miklavec)

I attached some suggestions for improving the original Portfile. (I would still suggest to modify the source repository in a way that will allow getting rid of special settings for MacPorts, but the port should work in.)

Another suggestion: it would be nice to put _blackbox_common.sh and _stack_lib.sh somewhere outside of bin if users aren't expected to call these directly (maybe somewhere under share or libexec, but other locations are possible as well).

comment:9 Changed 4 years ago by mojca (Mojca Miklavec)

A few more comments. There is a command

port -v livecheck

(if you are in vcs_blackbox already, there's no need to provide the port name, else add vcs_blackbox at the end of that command) that will tell you if there is a newer version available. There is no need for "1. Find tag name on github."

I already told you how to update the checksums: just delete the lines and run

port -v extract

I changed many aspects of the port to make use of the github PortGroup, so there is no need for extra settings. If you want the latest version, just replace

1.20150203 v

with the checksum of the commit or a tag or whatever. (Just note that you'll probably need to set the version separately if you use something like "stable".) The letter "v" is just to prepend something in front of the version to make a tag.

comment:10 Changed 4 years ago by mojca (Mojca Miklavec)

Description: modified (diff)

comment:11 Changed 4 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:12 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Committed Mojca's version of the port in r132962 with these additional changes:

  • added supported_archs noarch
  • removed / before ${prefix} since ${prefix} already begins with /
  • added comment to remind us that this project's Makefile uses DESTDIR in a nonstandard way
Note: See TracTickets for help on using tickets.