Opened 6 years ago

Closed 6 years ago

#46850 closed defect (fixed)

Wireshark 1.12.3 Segmentation fault

Reported by: greg@… Owned by: ghosthound
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc: wustenfuchs@…, hsivank@…, woody.anderson@…, robin@…, jere@…, ewen-naos-nz (Ewen McNeill), Feuermurmel (Michael Schwarz), Schamschula (Marius Schamschula), dershow, breiter (Brian Reiter), yoav.nir@…
Port: wireshark

Description

Hello,

I am seeing an issue using the wireshark port from within Yosemite. I've attempted to upgrade to 1.12.3 and while I am able to get it to compile, I get a Segmentation fault: 11 when I try to execute it. I get the same issue trying to compile 1.12.1 with or without ports as that is the version I'd like to actually use.

I have attached the Crash Log to the ticket. Any assistance with this would be great.

Attachments (8)

wireshark-12.1.3.crash (42.0 KB) - added by greg@… 6 years ago.
Crash Log
wireshark_2015-02-16-195709.crash (38.7 KB) - added by meitarm+macports@… 6 years ago.
Crash log for "Segmentation fault: 11" error after upgrading wireshark to 1.12.3 on Mac OS X 10.9 Mavericks
configure-pixmap-fix.diff (690 bytes) - added by ewen-naos-nz (Ewen McNeill) 6 years ago.
Patch to configure to comment out -DGDK_PIXBUF_DISABLE_DEPRECATED from CFLAGS
Portfile-wireshark.diff (854 bytes) - added by Schamschula (Marius Schamschula) 6 years ago.
wireshark_1.12.4_1-with-patch.png (126.6 KB) - added by ewen-naos-nz (Ewen McNeill) 6 years ago.
Wireshark 1.12.4_1 screenshot (top section, with icons)
wireshark+quartz+patch.png (194.3 KB) - added by breiter (Brian Reiter) 6 years ago.
Wireshark 1.12.4_1 with patch applied
wireshark-borken-icons-gtk3.png (399.6 KB) - added by breiter (Brian Reiter) 6 years ago.
Icons missing with +gtk3 build option
wireshark-gtk3+adwaita-icon-theme.png (422.4 KB) - added by breiter (Brian Reiter) 6 years ago.
wireskark gtk3 + adwait-icon-theme

Download all attachments as: .zip

Change History (38)

Changed 6 years ago by greg@…

Attachment: wireshark-12.1.3.crash added

Crash Log

comment:1 Changed 6 years ago by wustenfuchs@…

Cc: wustenfuchs@… added

Cc Me!

comment:2 Changed 6 years ago by wustenfuchs@…

Same issue.

Macbook 13” 5,1 / osx @10.10.2 / xcode @6.1.1 / macports @2.3.3

comment:3 Changed 6 years ago by larryv (Lawrence Velázquez)

Cc: hsivank@… added
Owner: changed from macports-tickets@… to opendarwin.org@…

comment:4 Changed 6 years ago by meitarm+macports@…

I am having the same issue: after I upgraded my wireshark to 1.12.3, trying to run it results in a Segmentation fault: 11 error, but unlike the original submitter I am on Mac OS X 10.9 Mavericks. I have also attached a crash log. Thanks for looking into this.

Changed 6 years ago by meitarm+macports@…

Crash log for "Segmentation fault: 11" error after upgrading wireshark to 1.12.3 on Mac OS X 10.9 Mavericks

comment:5 Changed 6 years ago by ghosthound

Owner: changed from opendarwin.org@… to ricci@…
Status: newassigned

wireshark 1.12.3 works for me (on 10.10.2). What version did you upgrade from? Are other GTK2/GTK3 apps having similar problems (in particular ones that use libgobject, that's where the actual crash is)? You can also try removing "-DGDK_PIXBUF_DISABLE_DEPRECATED" from configure as per this FreeBSD bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195980#c45 - if that works please reply here and we can incorporate that.

comment:6 Changed 6 years ago by wustenfuchs@…

In my case, not an upgrade. Fresh install of everything (Yosemite, XCode, Macports, Wireshark). I will check your suggestions when I have an opportunity if others haven't done so already. Thanks.

comment:7 Changed 6 years ago by woody.anderson@…

After upgrade to 1.12.13 my system also segv's.

XCode Version 6.1.1 (6A2008a)

uname -a: Darwin calculus.local 13.4.0 Darwin Kernel Version 13.4.0: Sun Aug 17 19:50:11 PDT 2014; root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64

previously installed version was: wireshark @1.10.7_1+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11

what file do i change to attempt the DGDK_PIXBUF_DISABLE_DEPRECATED related fix?

comment:8 Changed 6 years ago by woody.anderson@…

Cc: woody.anderson@… added

Cc Me!

comment:9 Changed 6 years ago by robin@…

Cc: robin@… added

Cc Me!

comment:10 in reply to:  7 Changed 6 years ago by ghosthound

Replying to woody.anderson@…:

After upgrade to 1.12.13 my system also segv's.

XCode Version 6.1.1 (6A2008a)

uname -a: Darwin calculus.local 13.4.0 Darwin Kernel Version 13.4.0: Sun Aug 17 19:50:11 PDT 2014; root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64

previously installed version was: wireshark @1.10.7_1+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11

what file do i change to attempt the DGDK_PIXBUF_DISABLE_DEPRECATED related fix?

Run through the patch phase, then edit the configure script to remove the '-DGDK_PIXBUF_DISABLE_DEPRECATED', then continue on with building and installing.

comment:11 Changed 6 years ago by greg@…

I am not sure if I know the 'proper' way to do what is described, however I did:

port patch wireshark

Then located the patched wireshark (located in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_wireshark/wireshark/work/wireshark-1.12.3), modified the configure file and commented the line which has the compile option 'DGDK_PIXBUF_DISABLE_DEPRECATED'. Then I did the following:

./configure make install

It does compile properly and I no longer get the segmentation fault when I execute it. However the way I built it, it naturally gets built into build directories of MacPorts and doesn't get installed in the normal paths like a port. Not sure if this was the only way to test this, but removing those compile options worked both for my regular non-ports version of Wireshark I built from source and also seems to allow this compile to work.

A few issues I notice though are that the Icons are not correct (some are missing), fonts are wrong, and the Plus's don't show up when narrowing in on traffic (they are there, but don't show up on the screen). The program seems to be working otherwise. There may be a little more missing to be fully compatible with the Yosemite and the new XCode.

comment:12 Changed 6 years ago by jeanfrancois.bertrand@…

I have been having this issue too.

Isnt the sequence to manually patch a port like this:

port patch wireshark

followed by:

port edit wireshark

port clean wireshark

port build wireshark

comment:13 Changed 6 years ago by jere@…

Cc: jere@… added

Cc Me!

comment:14 Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

Cc: macports@… added

Cc Me!

Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

Attachment: configure-pixmap-fix.diff added

Patch to configure to comment out -DGDK_PIXBUF_DISABLE_DEPRECATED from CFLAGS

comment:15 Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

Attached is configure-pixmap-fix.diff, which is a trivial patch to implement the "don't add -DGDK_PIXBUF_DISABLE_DEPRECATED to CPPFLAGS" which was mentioned in the FreeBSD ticket. With that placed in opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/net/wireshark/files, and this patchfiles setting:

patchfiles      patch-configure.diff \
                configure-pixmap-fix.diff

in /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/net/wireshark/Portfile, a rebuilt wireshark package seems to run rather than segfaulting.

See https://trac.macports.org/wiki/howto/PatchLocal for hints on how to apply a local patch like this. Thanks to the person who found the FreeBSD bug report (fixed in Dec 2014), as it made it much easier.

Note that the relevant bit of configure comes from configure.ac, but if you also patch configure.ac, then (a) you need automake @1.14.1_2 active (because it wants aclocal-1.14), and (b) that will result in running a bunch of autotools guff, which overwrites the other patch to the configure script, which means it fails to identify the Kerberos library, and the build fails :-( So we don't patch configure.ac. (That bit seems rather fragile, but I don't have time to untangle why it was done like that.)

Ewen

comment:16 Changed 6 years ago by Feuermurmel (Michael Schwarz)

Cc: michi.schwarz@… added

Cc Me!

Changed 6 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-wireshark.diff added

comment:17 Changed 6 years ago by Schamschula (Marius Schamschula)

Added patchfile to wireshark 1.12.4 Portfile. Also added sha256 hash.

comment:18 Changed 6 years ago by Schamschula (Marius Schamschula)

Cc: mschamschula@… added

Cc Me!

comment:19 Changed 6 years ago by dershow

Cc: dersh@… added

Cc Me!

comment:20 Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

In case it helps, I've confirmed that building 1.12.4 with configure-pixmap-fix.diff and Portfile-wireshark.diff (attached to this ticket) results in a wireshark that starts up correctly, but the in-Macports one, built without the patch, crashes on startup.

ewen@ashram:~$ port installed wireshark
The following ports are currently installed:
  wireshark @1.12.2_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11 (active)
ewen@ashram:~$ wireshark
Segmentation fault: 11
ewen@ashram:~$ port installed wireshark
The following ports are currently installed:
  wireshark @1.12.2_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_1+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11 (active)
ewen@ashram:~$ wireshark
ewen@ashram:~$ 

(In-Macports one first, built with the patch second.)

Maybe someone with MacPorts commit access can make this an official part of the MacPorts build? That seems to be the solution that FreeBSD adopted for their port.

Ewen

comment:21 in reply to:  20 Changed 6 years ago by breiter (Brian Reiter)

Replying to macports@…:

In case it helps, I've confirmed that building 1.12.4 with configure-pixmap-fix.diff and Portfile-wireshark.diff (attached to this ticket) results in a wireshark that starts up correctly, but the in-Macports one, built without the patch, crashes on startup.

ewen@ashram:~$ port installed wireshark
The following ports are currently installed:
  wireshark @1.12.2_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11 (active)
ewen@ashram:~$ wireshark
Segmentation fault: 11
ewen@ashram:~$ port installed wireshark
The following ports are currently installed:
  wireshark @1.12.2_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+adns+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.3_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
  wireshark @1.12.4_1+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11 (active)
ewen@ashram:~$ wireshark
ewen@ashram:~$ 

(In-Macports one first, built with the patch second.)

Maybe someone with MacPorts commit access can make this an official part of the MacPorts build? That seems to be the solution that FreeBSD adopted for their port.

Ewen

This solution works for me as well building with gtk2+quartz.

$ sudo port install -s wireshark
--->  Computing dependencies for wireshark
--->  Fetching distfiles for wireshark
--->  Verifying checksums for wireshark
--->  Extracting wireshark
--->  Applying patches to wireshark
--->  Configuring wireshark
--->  Building wireshark
--->  Staging wireshark into destroot
--->  Installing wireshark @1.12.4_1+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
--->  Deactivating wireshark @1.12.4_0+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
--->  Cleaning wireshark
--->  Activating wireshark @1.12.4_1+geoip+gnutls+ipv6+libgcrypt+libsmi+lua+rtp+ssl+x11
--->  Cleaning wireshark
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  No broken files found.
$ wireshark&
[1] 48179
2015-03-12 23:16:12.357 wireshark[48179:3040457] *** WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead. 

comment:22 Changed 6 years ago by ghosthound

Do all of the icons, etc. appear correctly with this patch?

Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

Wireshark 1.12.4_1 screenshot (top section, with icons)

comment:23 Changed 6 years ago by ewen-naos-nz (Ewen McNeill)

I've not exhaustively gone through looking at all the icons, but certainly all the icons I'd expect in all the panels I've used seem to display as expected. Eg, wireshark_1.12.4_1-with-patch.png shows the main screen, with all the icons I'd expect.

At minimum it's better than without the patch, where it just segfaults on start showing no icons... :-)

Ewen

Changed 6 years ago by breiter (Brian Reiter)

Attachment: wireshark+quartz+patch.png added

Wireshark 1.12.4_1 with patch applied

comment:24 in reply to:  23 Changed 6 years ago by breiter (Brian Reiter)

It is also working fine when built for Quartz rather than X11 in GTK2 as seen in screenshot wireshark+quartz+patch.png.

comment:25 Changed 6 years ago by breiter (Brian Reiter)

Cc: brian.reiter@… added

Cc Me!

comment:26 Changed 6 years ago by yoav.nir@…

CC me!

Changed 6 years ago by breiter (Brian Reiter)

Icons missing with +gtk3 build option

Changed 6 years ago by breiter (Brian Reiter)

wireskark gtk3 + adwait-icon-theme

comment:27 Changed 6 years ago by breiter (Brian Reiter)

There are many icons missing in the +gtk3 build. broken icons gtk3

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'document-open' for stock: Icon 'document-open' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'window-close' for stock: Icon 'window-close' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'view-refresh' for stock: Icon 'view-refresh' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'edit-find' for stock: Icon 'edit-find' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-previous' for stock: 

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-next' for stock: 

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-jump' for stock: 

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-top' for stock: Icon 'go-top' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-bottom' for stock: Icon 'go-bottom' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'zoom-in' for stock: Icon 'zoom-in' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'zoom-out' for stock: Icon 'zoom-out' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'zoom-original' for stock: Icon 'zoom-original' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'help-contents' for stock: Icon 'help-contents' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'document-open' for stock: Icon 'document-open' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'go-home' for stock: Icon 'go-home' not present in theme

(wireshark:70244): Gtk-WARNING **: Error loading theme icon 'help-contents' for stock: Icon 'help-contents' not present in theme

This is fixed by adding adwaita-icon-theme port (wireshark +gkk3 +adwaita-icon-theme):

port install adwaita-icon-theme.

comment:28 Changed 6 years ago by breiter (Brian Reiter)

For some reason some of the icons are colorless in the +gtk3 build, even with gnome-themes-standard (which includes adwaita-icon-theme installed.

comment:29 in reply to:  26 Changed 6 years ago by larryv (Lawrence Velázquez)

Cc: yoav.nir@… added

Replying to yoav.nir@…:

CC me!

You have to click the “CcMe!” button to be Cc’d.

comment:30 Changed 6 years ago by ghosthound

Resolution: fixed
Status: assignedclosed

configure pixmap patch applied in r133911, thanks!

Note: See TracTickets for help on using tickets.