Opened 9 years ago

Closed 9 years ago

#46933 closed update (fixed)

stimfit @0.14.1: update 0.14.2

Reported by: neurodroid (Christoph Schmidt-Hieber) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: petrrr, mojca (Mojca Miklavec), jyrkiwahlstedt
Port: stimfit

Description

  • Fixes some errors during event detection

See related ticket #46932

Attachments (2)

Portfile-stimfit.diff (1.1 KB) - added by neurodroid (Christoph Schmidt-Hieber) 9 years ago.
stimfit Portfile patch
Portfile-stimfit_0.14.5.diff (833 bytes) - added by neurodroid (Christoph Schmidt-Hieber) 9 years ago.
stimfit Portfile patch

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by neurodroid (Christoph Schmidt-Hieber)

Attachment: Portfile-stimfit.diff added

stimfit Portfile patch

comment:1 Changed 9 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:2 Changed 9 years ago by mojca (Mojca Miklavec)

For some reason the compilation fails for me:

  CXX      libstimfit_la-app.lo
In file included from ./gui/app.cpp:51:
./gui/./app.h:207:10: fatal error: 'wx/wxPython/wxPython.h' file not found
#include <wx/wxPython/wxPython.h>
         ^
1 error generated.
make[3]: *** [libstimfit_la-app.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

I wanted to diagnose the problem, but when I cd inside and run sudo make V=1, it fails with another error:

> sudo make V=1
make  all-recursive
Making all in src
Making all in libstfio
make[3]: Nothing to be done for `all'.
Making all in libstfnum
make[3]: Nothing to be done for `all'.
Making all in stimfit
/bin/sh ../../libtool  --tag=CXX   --mode=compile /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7  -DWITH_PYTHON -DHAVE_LAPACK -DHAVE_LAPACK_SUFFIX -DH5_USE_16_API -O2 -g -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxPython/3.0/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxPython/3.0/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__  -pipe -Os -arch x86_64 -stdlib=libstdc++ -fPIC  -Wall -c -o libstimfit_la-app.lo `test -f './gui/app.cpp' || echo './'`./gui/app.cpp
libtool: compile:  /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7 -DWITH_PYTHON -DHAVE_LAPACK -DHAVE_LAPACK_SUFFIX -DH5_USE_16_API -O2 -g -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxPython/3.0/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxPython/3.0/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -pipe -Os -arch x86_64 -stdlib=libstdc++ -fPIC -Wall -c ./gui/app.cpp  -fno-common -DPIC -o .libs/libstimfit_la-app.o
In file included from ./gui/app.cpp:51:
In file included from ./gui/./app.h:176:
./gui/./../stf.h:27:10: fatal error: 'boost/function.hpp' file not found
#include <boost/function.hpp>
         ^
1 error generated.
make[3]: *** [libstimfit_la-app.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

I'm a bit confused.

comment:3 Changed 9 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:4 Changed 9 years ago by neurodroid (Christoph Schmidt-Hieber)

I'll look into this. It would make sense to update directly to v0.14.5 at the same time. For this we'd need libbiosig to be updated to v1.6.3 so that we can use the biosig variant. See #47029.

comment:5 Changed 9 years ago by mojca (Mojca Miklavec)

Cc: jwa@… added

comment:6 Changed 9 years ago by mojca (Mojca Miklavec)

I believe that r129094 (or rather: the previous update) was the culprit. I increased the revision of wxPython-3.0 in r133530, but I didn't test it yet.

comment:7 Changed 9 years ago by mojca (Mojca Miklavec)

Indeed. It works now. I also tried to compile version 0.14.5debian with +libbiosig and the latest version of the library and it was successful.

(I find it weird that the domain name jumps to google code where you neither have the source code nor the downloads up to date.)

If you have time, please also take a look at the output of port -v build stimfit. It throws a number of different compiler warnings.

I would suggest to make any kind of change soon. I'm not sure if the port is still functional after I upgraded biosig.

Changed 9 years ago by neurodroid (Christoph Schmidt-Hieber)

stimfit Portfile patch

comment:8 Changed 9 years ago by neurodroid (Christoph Schmidt-Hieber)

Updated patch attached (v0.14.5), better handling of libbiosig errors

comment:9 Changed 9 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed

Committed in r133540 with two other trivial patches.

Note: See TracTickets for help on using tickets.