Opened 9 years ago

Closed 9 years ago

#46975 closed update (fixed)

kde4-runtime update to 14.12.2

Reported by: RJVB (René Bertin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: NicosPavlov
Port: kde4-runtime

Description

KDE4 development continues slowly, mostly bug fixes and most of the time without leading to releases. KDE Runtime has adopted a different versioning scheme more in line with the KDE Applications versioning. The patch attached brings the port up to date, sets the version to 4.14.12.2.

This includes my modifications to make the KDE wastebin use OS X's trash (which that e.g. photos deleted from Digikam end up in the system's trash and not somewhere where they'll linger for unknown amounts of time). It also includes modifications to generate usable stack backtraces with lldb, in drkonqi, and the multimedia control module has been activated.

Attachments (4)

kde4runtime-14.12.diff (4.5 KB) - added by RJVB (René Bertin) 9 years ago.
patch-support-for-lldb.diff (8.8 KB) - added by RJVB (René Bertin) 9 years ago.
patch-make-kioexec-agent.diff (1.8 KB) - added by RJVB (René Bertin) 9 years ago.
patch-phonon-cmakelists.diff (2.8 KB) - added by RJVB (René Bertin) 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by RJVB (René Bertin)

Attachment: kde4runtime-14.12.diff added

comment:1 Changed 9 years ago by NicosPavlov

There are some issues to build the Portfile as given:

  • The Portfile is referring two patches which are not provided.
  • The hash you are using for downloading the sources is v15.03.80 and not 4.12.3 as announced. Is this intended?
  • I did not look yet at the multimedia activation, since the port cannot be built as is.

Changed 9 years ago by RJVB (René Bertin)

Attachment: patch-support-for-lldb.diff added

Changed 9 years ago by RJVB (René Bertin)

Changed 9 years ago by RJVB (René Bertin)

comment:2 in reply to:  1 Changed 9 years ago by RJVB (René Bertin)

Replying to nicos@…:

There are some issues to build the Portfile as given:

  • The Portfile is referring two patches which are not provided.

My bad. I've attached all 3 patches now.

  • The hash you are using for downloading the sources is v15.03.80 and not 4.12.3 as announced. Is this intended?

Yes. I don't know what the new versioning scheme represents, nor to be honest how I came to the 14.12.2 upstream version. It's possible that this refers to the KDE Applications version that was release around the time the tag I fetch was committed. I do remember trying to find a version number that wouldn't suggest a huge jump from the 4.14.3 version currently in MacPorts. Where do you see 4.12.3, thought?

  • I did not look yet at the multimedia activation, since the port cannot be built as is.

comment:3 Changed 9 years ago by NicosPavlov

Everything seems good to me, but I still would like to settle the versioning. For the 4.12.3, I just did not look properly.

The fact of combining a made-up version number plus the date does seems pretty complicated to me, while not being easy to follow in regards to the real ones anyway. I would suggest to be consistent with other ports (such as kde4-workspace, recently committed), and to set it to 4.14.4.date, so slightly higher than the last release, and dates to relate to the git commit. Would this sound good?

comment:4 Changed 9 years ago by RJVB (René Bertin)

Fine with me too.

I just realised how I arrived at 14.12.x: git describe ...

Current git head gives v15.03.80-34-g6f6d586, for instance (and yes, that's still a KDE4 version).

I added a 4. before the 14.12.x string to avoid a too big jump, a bit like how Debian and Ubuntu prefix 4: or 4. to certain KDE and Qt "ports".

comment:5 Changed 9 years ago by NicosPavlov

Resolution: fixed
Status: newclosed

Alright. Committed in r135470.

Note: See TracTickets for help on using tickets.