Opened 6 years ago

Closed 5 years ago

#47125 closed submission (fixed)

port submission: py-pykde4

Reported by: RJVB (René Bertin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: NicosPavlov, petrrr
Port: py-pykde4

Description

It's taken me a while, but here is port:py-pykde4, finally. It installs PyKDE4 for Python versions 2.7 and 3.2-3.4 . Some examples are included in the project, and I'll be uploading a real-world example later today.

I tried to make this depend on the Python portgroup, but it turned out too cumbersome to reset the configure and build settings to appropriate values.

Tested on OS X 10.9 with Qt 4.8.6 (installed in "concurrent" mode) and KDE 4.14.5 .

Attachments (15)

add_qt_kde_definitions.diff (687 bytes) - added by RJVB (René Bertin) 6 years ago.
fix_kpythonpluginfactory_build.diff (796 bytes) - added by RJVB (René Bertin) 6 years ago.
kubuntu_include_dirs.diff (1.2 KB) - added by RJVB (René Bertin) 6 years ago.
kubuntu_kpythonpluginfactory_3.2support.diff (1.1 KB) - added by RJVB (René Bertin) 6 years ago.
make_pykde4_respect_sip_flags.diff (986 bytes) - added by RJVB (René Bertin) 6 years ago.
optional_install_sip_files.diff (1.6 KB) - added by RJVB (René Bertin) 6 years ago.
python3.3.diff (463 bytes) - added by RJVB (René Bertin) 6 years ago.
python_modules_dont_link_against_libpython.diff (1.0 KB) - added by RJVB (René Bertin) 6 years ago.
pythonpluginfactory_python3.diff (3.7 KB) - added by RJVB (René Bertin) 6 years ago.
pythonpluginfactory_use_versioned_python_lib.diff (716 bytes) - added by RJVB (René Bertin) 6 years ago.
pykde4-macports-adaptations.diff (14.0 KB) - added by RJVB (René Bertin) 6 years ago.
pykde4-macports-adaptations2.diff (45.2 KB) - added by RJVB (René Bertin) 6 years ago.
pykde4-macports-adaptations-noDLFCN.diff (559 bytes) - added by RJVB (René Bertin) 6 years ago.
pykde4-macports-adaptations-toolongfilename.diff (810 bytes) - added by RJVB (René Bertin) 6 years ago.
Portfile (9.0 KB) - added by RJVB (René Bertin) 6 years ago.

Download all attachments as: .zip

Change History (26)

Changed 6 years ago by RJVB (René Bertin)

Attachment: add_qt_kde_definitions.diff added

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Attachment: kubuntu_include_dirs.diff added

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Attachment: python3.3.diff added

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

Changed 6 years ago by RJVB (René Bertin)

comment:1 Changed 6 years ago by RJVB (René Bertin)

Aargh, could someone please change the title to "port submission: py-pykde4" ??

comment:2 Changed 6 years ago by larryv (Lawrence Velázquez)

Summary: port submission: py-pkykde4port submission: py-pykde4

Don’t bother with Python 3.2 and 3.3, which are deprecated.

comment:3 Changed 6 years ago by NicosPavlov

Nice work getting this one to compile. I never could get past some of the errors. There are some small syntax issues in the Portfile, though. Just in case, it is also possible to use the command "port lint" to automatically detect several of them.

  • Openmaintainer should not be used alone. It should be either nomaintainer, or $NAME openmaintainer. Do you intend to take maintainership?
  • Homepage is required.
  • This may not be that important, especially as the patches were borrowed from another platform, but from their name, several of them should not be needed as we intentionally do not support certain python versions. I wonder if it would be worth cleaning them up, but I did not look it up in details yet.

Changed 6 years ago by RJVB (René Bertin)

Attachment: Portfile added

comment:4 Changed 6 years ago by RJVB (René Bertin)

It was not the easiest project to get to build and function, no :)

  • There appears to be no real homepage, so I picked a page that seems to be the best alternative to one.
  • the python3.3.diff patch appears to be unnecessary, indeed. The other one (kubuntu*3.2support.diff) actually concerns all Python versions starting with 3.2, so that one we'll want to leave in...

I've also added a -docs subport as an additional dependency for the +docs variants. Since there's no Python-version-specific documentation the +docs variants would install the same documentation, which would be overkill if it were possible.

comment:5 in reply to:  4 Changed 6 years ago by larryv (Lawrence Velázquez)

Replying to rjvbertin@…:

I've also added a -docs subport as an additional dependency for the +docs variants.

There’s no reason to keep the +docs variants around if they just add a new dependency.

comment:6 Changed 6 years ago by RJVB (René Bertin)

True, but they're provided by the kde4 PortGroup ... they can't be undefined, right?

comment:7 Changed 5 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:8 Changed 5 years ago by NicosPavlov

The docs subport seems overkill to me. It complicates the Portfile, and does not change the additional dependency. The only thing it provides is the ability to build the documentation independently from the main port, which is not really needed. Why not using the variant directly?

comment:9 Changed 5 years ago by RJVB (René Bertin)

I guess I didn't realise one could fine-tune the behaviour of a variant defined in the PortGroup (can one?!)...

Edit:I don't recall to what extent this port is concerned, but as a general rule I find it a better solution if documentation can be installed (and uninstalled) independently from (and possibly even without installing) the main port. This is especially useful for large ports that take way too long to build and/or install a huge quantity of documentation.

Last edited 5 years ago by RJVB (René Bertin) (previous) (diff)

comment:10 Changed 5 years ago by NicosPavlov

In principle, it should be possible to modify the requirements, such as by using "depends_build-delete", but it did not seem to work in this case, for a reason I don't really get.

If you have a reason to keep the subport, I'll take a final look at the port before committing it.

comment:11 Changed 5 years ago by NicosPavlov

Resolution: fixed
Status: newclosed

Port committed in r135592.

Note: See TracTickets for help on using tickets.