Opened 4 years ago

Closed 4 years ago

#47387 closed update (fixed)

tidy: update to 4.9.24

Reported by: macports_org@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: Ionic (Mihai Moldovan)
Port: tidy

Description (last modified by Ionic (Mihai Moldovan))

Please update HTML Tidy. There are much more recent versions than what was available in 2012!

Note: I understand from an IRC conversation with "Ionic" that they aren't properly tagging their releases in GitHub. I'm also contacting them to ask them to start doing this. :-)

http://www.html-tidy.org
https://github.com/htacg/tidy-html5

Attachments (2)

patch-CMakeLists.txt.diff (364 bytes) - added by ryandesign (Ryan Schmidt) 4 years ago.
tidy-4.9.24.diff (2.4 KB) - added by ryandesign (Ryan Schmidt) 4 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 4 years ago by Ionic (Mihai Moldovan)

Owner: changed from macports-tickets@… to ryandesign@…
Port: tidy added

comment:2 Changed 4 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)

comment:3 Changed 4 years ago by Ionic (Mihai Moldovan)

Description: modified (diff)

Also being a jerk about the nickname and everything.

comment:4 Changed 4 years ago by larryv (Lawrence Velázquez)

The project does have “versions” of sorts, so it might be feasible to switch over to proper version numbers (although we’d still have to fetch Git commits).

https://github.com/htacg/tidy-html5/blob/master/version.txt

comment:5 Changed 4 years ago by Ionic (Mihai Moldovan)

Owner: changed from ryandesign@… to ionic@…
Status: newassigned

Turns out the port was updated, but the version not incremented. Doing that myself now.

comment:6 Changed 4 years ago by Ionic (Mihai Moldovan)

Owner: changed from ionic@… to ryandesign@…
Status: assignednew

Rather turns out I cannot read, as always. While r131697 did change the github.setup line, the commit ID was left intact, so the port is still in its stale 2012 state. Re-assigning back, sorry for all the noise...

comment:7 Changed 4 years ago by ryandesign (Ryan Schmidt)

Status: newassigned

In January, the developer of tidy asked me to change the tidy port to build via cmake or Xcode, and said version 5.0.0 would be released within weeks, but it does not appear to have happened yet. I'll look into updating to a newer development version.

comment:8 Changed 4 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Summary: update HTML Tidytidy: update to 4.9.24

Not sure when it changed, but compared with the 2012 version we currently have in MacPorts, in the current 4.9.24 version, the program name has changed from tidy to tidy5 and the library name has changed from libtidy to libtidy5. We have several ports declaring dependencies on the tidy port. I suspect they may need to be updated for these changes. I'll attach my portfile update for tidy so far but won't commit it until I've tested and fixed ths dependents.

Changed 4 years ago by ryandesign (Ryan Schmidt)

Attachment: patch-CMakeLists.txt.diff added

Changed 4 years ago by ryandesign (Ryan Schmidt)

Attachment: tidy-4.9.24.diff added

comment:9 in reply to:  8 Changed 4 years ago by macports_org@…

Replying to ryandesign@…:

Compared with the 2012 version we currently have in MacPorts, in the current 4.9.24 version, the program name has changed from tidy to tidy5 and the library name has changed from libtidy to libtidy5.

You may want to hold off for a release. That MAY be just for testing/beta purposes -- I believe I saw discussion on that site that the program would remain "tidy".

Last edited 4 years ago by macports_org@… (previous) (diff)

comment:10 Changed 4 years ago by macports_org@…

Here it is: https://github.com/htacg/tidy-html5/issues/46

The name will remain just "tidy".

EDIT TO ADD: Especially note one of the later comments, regarding a script to assist the reversion. Maybe useful to MacPorts?

Last edited 4 years ago by macports_org@… (previous) (diff)

comment:11 Changed 4 years ago by ryandesign (Ryan Schmidt)

Thanks, that does work. I can edit the CMakeLists.txt to change the variable from tidy5 back to tidy. Now I just need to test other ports to make sure they still work with this new version of tidy.

comment:12 Changed 4 years ago by Ionic (Mihai Moldovan)

Cc: ionic@… added

comment:13 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.