cantera: download from github

[macports@…]

Cantera is moving to GitHub (see ​https://groups.google.com/forum/?fromgroups#!topic/cantera-users/-JyScUZm0O0)

This update just changes the download source.

[macports@…]

Cantera 2.1.2 on GitHub - Diff

[mf2k (Frank Schima)]

Thanks! ​Per the guidelines, please use a unified diff format for your patch.

[macports@…]

Thank you for pointing me to the right paragraph in the guidelines!

[larryv (Lawrence Velázquez)]

I haven’t looked at this at all, but make sure that you don’t have to account for a stealth update here (PortfileRecipes#stealth-updates).

[macports@…]

Cantera 2.1.2 on GitHub - Diff

[macports@…]

Thanks, that should definitely be there! I added that line.

[ryandesign (Ryan Carsten Schmidt)]

If a stealth update had occurred, the checksums would have changed, but you did not indicate changed checksums. In fact the checksums do change if we use your patch as-is, because your patch makes the port download from a tarball automatically generated by github from the git repository. Since this project also offers release downloads, we should use those instead, by using github.tarball_from releases. The checksums match those from sourceforge, so no stealth update has occurred and there is no need to change the dist_subdir.

Note also that the github.setup line is meant to replace, not supplement, the name and version lines; you would only keep the name or version lines if their values differed from those specified in the github.setup line, but in this case (and in most cases) they don't.

The cantera web site still tells people to download from SourceForge. You might want to let them know they should update that to refer people to github instead.

[ryandesign (Ryan Carsten Schmidt)]

r134890