Opened 6 years ago

Closed 5 years ago

#47482 closed defect (fixed)

Xcode 6.3 breakage of strigi 0.7.8 build

Reported by: howarth.at.macports@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc: diochnos, kurthindenburg (Kurt Hindenburg)
Port: strigi

Description

I have tested this directly on MacPorts yet, but suspect you will see the same issue with the Apple clang 6.1 compiler as we do on fink. The storage 0.7.8 build fails under Xcode 6.3 (but not Xcode 6.2 or earlier) with the error...

[ 92%] Building CXX object
strigidaemon/bin/daemon/xesam/CMakeFiles/xesam.dir/xesamsession.cpp.o
cd /sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/build/strigidaemon/bin/daemon/xesam
&& /sw/var/lib/fink/path-prefix-clang/c++    -MD -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-mmacosx-version-min=10.10
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/libstreams/include
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/build/libstreams/include
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/libstreamanalyzer/include
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/build/libstreamanalyzer/include
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/include
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon/xsd
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/build/strigidaemon
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/build/strigidaemon/bin/daemon/dbus
-I/sw/include/dbus-1.0 -I/sw/lib/dbus-1.0/include -I/sw/include
-I/sw/include/libxml2
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/combinedindex
-I/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon
   -fPIC -o CMakeFiles/xesam.dir/xesamsession.cpp.o -c
/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.cpp
In file included from
/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.cpp:22:
In file included from
/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.h:24:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/list:2060:18:
error: invalid operands to binary expression
      ('const value_type' (aka 'const XesamSearch') and 'const
value_type' (aka 'const XesamSearch'))
        if (*__i == __x)
            ~~~~ ^  ~~~
/sw/src/fink.build/strigi-0.7.8-2/strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.cpp:200:17:
note: in instantiation of member function 'std::__1::list<XesamSearch,
      std::__1::allocator<XesamSearch> >::remove' requested here
    p->searches.remove(search);
                ^
1 error generated.
strigidaemon/bin/daemon/xesam/CMakeFiles/xesam.dir/build.make:100:

Change History (11)

comment:1 Changed 6 years ago by howarth.at.macports@…

Of cours that should be strigi and not storage.

Version 0, edited 6 years ago by howarth.at.macports@… (next)

comment:2 Changed 6 years ago by dbevans (David B. Evans)

Summary: Xcode 6.3 breakage of storage 0.7.8 buildXcode 6.3 breakage of strigi 0.7.8 build

comment:3 Changed 6 years ago by howarth.at.macports@…

I have verified on fink that this breakage in compiling strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.cpp is present in the llvm.org clang 3.5.2 compilers.

comment:4 Changed 6 years ago by howarth.at.macports@…

On fink, I am able to comment out the offending line...

p->searches.remove(search);

in strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsession.cpp without any additional regressions showing up in the test suite. This allows Apple Clang 6.1 to build the package. The current declaration for this in strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsearch.h

 bool operator==(const XesamSearch& xs) { return p == xs.p; }

does match the usage of that call according to llvm.org clang 3.5 or later.

Last edited 6 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:5 Changed 6 years ago by howarth.at.macports@…

Opened https://llvm.org/bugs/show_bug.cgi?id=23274 in case the clang developers have any suggestions of a proper fix.

comment:6 Changed 6 years ago by howarth.at.macports@…

Proper fix already exist at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196603

--- strigi-0.7.8.orig/strigidaemon/bin/daemon/xesam/xesamsearch.h       2013-01-25 12:49:35.000000000 -0500
+++ strigi-0.7.8/strigidaemon/bin/daemon/xesam/xesamsearch.h    2015-04-17 19:57:05.000000000 -0400
@@ -43,7 +43,7 @@
     XesamSearch(Private* p);
     ~XesamSearch();
     void operator=(const XesamSearch& xs);
-    bool operator==(const XesamSearch& xs) { return p == xs.p; }
+    bool operator==(const XesamSearch& xs) const { return p == xs.p; }
     void startSearch();
     void getHitCount(void* msg);
     void getHits(void* msg, uint32_t num);

comment:7 Changed 6 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to clubjuggler@…

comment:8 Changed 6 years ago by mf2k (Frank Schima)

Owner: changed from clubjuggler@… to macports-tickets@…

This port no longer has a maintainer. See #47483.

comment:9 Changed 5 years ago by diochnos

Cc: diochnos@… added

Cc Me!

comment:10 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:11 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

fixed in other ticket

strigi: add patch to allow building XCode >= 6.3 #48673

Note: See TracTickets for help on using tickets.