Opened 9 years ago

Closed 9 years ago

#47681 closed defect (fixed)

`hg status' crashes on newly created repository

Reported by: veedeehjay@… Owned by: seanfarley (Sean Farley)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc:
Port: mercurial

Description

this happens with mercurial@3.3.3 under OSX 10.10.3. the following should reproducibly crash if the hggit' is requested in ~/.hgrc

mkdir new
cd new
hg init
hg status

with the message:

** unknown exception encountered, please report by visiting
** http://mercurial.selenic.com/wiki/BugTracker
** Python 2.7.9 (default, Dec 13 2014, 15:13:49) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)]
** Mercurial Distributed SCM (version 3.3.3)
** Extensions loaded: convert, rebase, fetch, graphlog, extdiff, hgk, color, hgsubversion, hggit, churn, pager, strip, mq, transplant
Traceback (most recent call last):
  File "/opt/local/bin/hg", line 43, in <module>
...
LOTS MORE
...
 File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/mercurial/scmutil.py", line 1105, in finddirs
    pos = path.rfind('/')
AttributeError: 'tuple' object has no attribute 'rfind'

two observations:

  1. without the hggit extension the problem goes away here
  1. using the mercurial-devel instead of themercurial port also makes the problem go away even in the presence of hggit. whether it's a problem of mercurial or the py-hggit port I canot say...

Change History (8)

comment:1 Changed 9 years ago by mf2k (Frank Schima)

Priority: HighNormal

The Priority field is for use by Macports team members only.

comment:2 Changed 9 years ago by veedeehjay@…

apologies: "observation 2" in previous post is WRONG: I had the hggit extension still deactivated in ~/.hgrc when doing the test with `mercurial-devel'. so in fact both, mercurial +and+ mercurial-devel crash as desribed above if the hggit extension is requested. it might therefore be a problem of that extension, after all?

I also note, that `hg stat' works just fine with my old, existing repos. only the newly created ones are affected.

comment:3 Changed 9 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to sean@…

comment:4 in reply to:  2 ; Changed 9 years ago by seanfarley (Sean Farley)

Replying to veedeehjay@…:

apologies: "observation 2" in previous post is WRONG: I had the hggit extension still deactivated in ~/.hgrc when doing the test with `mercurial-devel'. so in fact both, mercurial +and+ mercurial-devel crash as desribed above if the hggit extension is requested. it might therefore be a problem of that extension, after all?

I also note, that `hg stat' works just fine with my old, existing repos. only the newly created ones are affected.

Yes, the problem is hg-git. I use mercurial-devel with py27-hggit-devel. In fact, hg-git add quite a bit of overhead so I disable it globally and only enable it on repos that need it in $PROJECT/.hg/hgrc. Also, I'm updating all these ports today so that might help as well.

comment:5 in reply to:  4 Changed 9 years ago by veedeehjay@…

Replying to sean@…:

Replying to veedeehjay@…:

apologies: "observation 2" in previous post is WRONG: I had the hggit extension still deactivated in ~/.hgrc when doing the test with `mercurial-devel'. so in fact both, mercurial +and+ mercurial-devel crash as desribed above if the hggit extension is requested. it might therefore be a problem of that extension, after all?

I also note, that `hg stat' works just fine with my old, existing repos. only the newly created ones are affected.

Yes, the problem is hg-git. I use mercurial-devel with py27-hggit-devel. In fact, hg-git add quite a bit of overhead so I disable it globally and only enable it on repos that need it in $PROJECT/.hg/hgrc. Also, I'm updating all these ports today so that might help as well.

I see. thanks for clarifying. and I will follow suit. in any case it seems a bug in hggit, then -- is it a known one or should it be reported to the mercurial guys (or whoever is behind hggit)?

comment:6 in reply to:  4 Changed 9 years ago by veedeehjay@…

Replying to sean@…:

Replying to veedeehjay@…:

apologies: "observation 2" in previous post is WRONG: I had the hggit extension still deactivated in ~/.hgrc when doing the test with `mercurial-devel'. so in fact both, mercurial +and+ mercurial-devel crash as desribed above if the hggit extension is requested. it might therefore be a problem of that extension, after all?

I also note, that `hg stat' works just fine with my old, existing repos. only the newly created ones are affected.

Yes, the problem is hg-git. I use mercurial-devel with py27-hggit-devel. In fact, hg-git add quite a bit of overhead so I disable it globally and only enable it on repos that need it in $PROJECT/.hg/hgrc. Also, I'm updating all these ports today so that might help as well.

I see. thanks for clarifying. and I will follow suit. in any case it seems a bug in hggit, then -- is it a known one or should it be reported to the mercurial guys (or whoever is behind hggit)?

comment:7 Changed 9 years ago by seanfarley (Sean Farley)

The bug has already been fixed ... I just need to update :-)

comment:8 Changed 9 years ago by seanfarley (Sean Farley)

Resolution: fixed
Status: newclosed

Should be fix now.

Note: See TracTickets for help on using tickets.