freetype: revert header layout to prevent conflicts with ftgl

[repagh (Rene van Paassen)]

Freetype used to install most header files in

<includedir>/freetype2/freetype

for 2.5.5, this changed to:

<includedir>/freetype2

This creates a conflict when attempting to use ftgl, which depends on freetype; on a case-insensitive mac (as most are), the ftgl FTGlyph.h is confused with freetype's ftglyph.h. For compilation with freetype, the <includedir>/freetype2 dir needs to be in the include path, which makes that all header files there are visible to the compiler.

Attached portfile path reverts to the old install path, and adjusts the <includedir>/freetype2/config/ftheader.h file accordingly.

I also made a bug report for freetyps, no idea whether and when this is taken up.

[repagh (Rene van Paassen)]

diff for port file

[ryandesign (Ryan Carsten Schmidt)]

Replying to rene.vanpaassen@…:

Attached portfile path reverts to the old install path, and adjusts the <includedir>/freetype2/config/ftheader.h file accordingly.

No, we're not going to do that.

This is an ​FTGL bug. They should rename their header files.

[ryandesign (Ryan Carsten Schmidt)]

See also #41572.

Unfortunately the last ftgl release was in 2008 so the project may be dead and we may have to fix it ourselves.

[mojca (Mojca Miklavec)]

Cc Me!

[repagh (Rene van Paassen)]

I still think the main problem is with freetype2. With the current set-up;

pkg-config --cflags freetype2
-I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/libpng16 

over 40 files with short names -- and short prefixes, ft or tt -- are added to the compiler's search path. If all libraries would do that, projects with more than just a few libraries become a compilation nightmare. In version 2.5.0 (don't know where the exact change was), most of these files were still under a directory freetype/

FTGL, although old, still nicely hides its file names under an FTGL/ directory.

[ryandesign (Ryan Carsten Schmidt)]

If you believe the freetype headers should be moved back to where they were before, you would have to contact the freetype developers about that. I don't want to second-guess them.

[mojca (Mojca Miklavec)]

See also ​http://savannah.nongnu.org/bugs/?40972

[repagh (Rene van Paassen)]

Yes, I tried.

Let's see if they come to their senses, but indeed the 40972 (which I didn't find on freetype by the way, I opened a new bug report) was flagged as a wontfix.

[ryandesign (Ryan Carsten Schmidt)]

It looks like they have come to their senses after all. The CHANGES file in the freetype 2.6.1 release says:

  II. IMPORTANT CHANGES

    - The header  file layout  has been  changed (again),  moving  all
      header files except `ft2build.h' into a subdirectory tree.

      Doing so  reduces the  possibility of  header file  name clashes
      (e.g., FTGL's  `FTGlyph.h' with FreeType's `ftglyph.h')  on case
      insensitive file systems like Mac OS X or Windows.