Opened 5 years ago

Closed 5 years ago

#48142 closed defect (fixed)

jemalloc @3.6.0_0: fix dylib install name

Reported by: jwatzman@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: yoanlin93@…
Port: jemalloc

Description

In jemalloc 3.6.0, the dylib install name is not correctly set, meaning that any executable linking against libjemalloc.dylib needs to set DYLD_LIBRARY_PATH or DYLD_FALLBACK_LIBRARY_PATH, both of which are strongly recommended not to have set.

This has already been fixed upstream in jemalloc trunk, cf. https://github.com/jemalloc/jemalloc/commit/f1f2b4542902c5bc14788f6c2d4190b422e5901f, but there is not a release with this patch available yet. This portfile update includes that patch, applied to version 3.6.0, in order to make dynamic linking against jemalloc usable.

Two files will be attached: a diff of the Portfile update, as well a new patch: an adaptation of upstream's https://github.com/jemalloc/jemalloc/commit/f1f2b4542902c5bc14788f6c2d4190b422e5901f.patch to be applied against 3.6.0.

Attachments (2)

Portfile.diff (626 bytes) - added by jwatzman@… 5 years ago.
patch-install-name.diff (941 bytes) - added by jwatzman@… 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by jwatzman@…

Attachment: Portfile.diff added

Changed 5 years ago by jwatzman@…

Attachment: patch-install-name.diff added

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Cc: yoanlin93@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to yoanlin93@…
Type: updateenhancement
Version: 2.3.3

comment:2 Changed 5 years ago by jwatzman@…

Ping! yoanlin93, can you commit this, or since it's openmaintainer, can someone else, since it's been 2 weeks? This fixes a major usability problem with jemalloc on OS X, and should be safe since the fix is taken from upstream anyways.

comment:3 Changed 5 years ago by cornelius.howl@…

Hi jwatzman,

sorry I don't have permission to commit this into repository. we need macports developers to help us. :)

comment:4 in reply to:  3 Changed 5 years ago by larryv (Lawrence Velázquez)

Cc: yoanlin93@… added
Owner: changed from yoanlin93@… to larryv@…
Status: newassigned
Summary: jemalloc @3.6.0 fix dylib install namejemalloc @3.6.0_0: fix dylib install name
Type: enhancementdefect

I will take care of this soon.

comment:5 Changed 5 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: assignedclosed

Maintainer timeout, r138432, using a different patch that doesn’t touch configure.ac.

Note: See TracTickets for help on using tickets.