Opened 5 years ago

Closed 5 years ago

#48497 closed update (fixed)

vnstat: update to 1.14

Reported by: youvegotmoxie@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: vnstat

Description

net/vnstat is a few versions behind and set to nomaintainer, I would like to maintain the port.

Attachments (1)

change-vnstat-maintainer.diff (2.8 KB) - added by youvegotmoxie@… 5 years ago.
updated patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Thanks. Some comments:

  • The revision line should be removed.
  • Every distfile should have at least 2 checksum types. You only listed a sha256 checksum; please add a rmd160 checksum.
  • The way that you are handling the config file is unusual. The usual way would be: in post-activate, check if ${prefix}/etc/vnstat.conf exists, and if not, copy vnstat.conf-local to vnstat.conf. Print notes telling the user they can edit vnstat.conf.

comment:2 Changed 5 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added; net vnstat removed
Port: vnstat added; haspatch removed
Summary: change maintainership net/vnstatvnstat: update to 1.14
Type: enhancementupdate

comment:3 Changed 5 years ago by youvegotmoxie@…

Thank you for the feedback, I will submit an updated patch shortly.

Changed 5 years ago by youvegotmoxie@…

updated patch

comment:4 Changed 5 years ago by youvegotmoxie@…

Reverted back to the way the original Portfile handled the configuration file.

comment:5 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

I made a few changes w/ respect to the conf file - let me know if you have any issues - you might also conside adding openmaintainer so other people can make trival updates.

r139348

Note: See TracTickets for help on using tickets.