Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#48588 closed defect (duplicate)

Patch to fix trac: 41984

Reported by: wdc@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: micah.lerner@…
Port: gtksourceview2

Description (last modified by Ionic (Mihai Moldovan))

This new port file swaps me in as maintainer, and fixes the defect reported in Trac #41984.

A previous patch file, patch-gtksourceview_gtksourceview-i18n.c.diff is eliminated.

A different MacOS gtk2 integration is followed. gtk-osx-application-gtk2 is used instead of ige-mac-integration. This is necessary when both gtk2 and gtk3 ports are installed. Recognizing that gtk integration is a moving target, this new integration is more in harmony with upstream.

(This is my first time taking over a port, and I may be imperfectly understanding the instructions. I hope that fixing the bug and taking over the port in the same ticket is ok.)

Attachments (2)

patch-gtkosxapplication.diff (3.4 KB) - added by wdc@… 5 years ago.
Corrects defect 41984
change-gtksourceview2-maintainer.diff (1.6 KB) - added by wdc@… 5 years ago.
Take over as port maintainer, and use the patch file to correct the defect.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by wdc@…

Corrects defect 41984

Changed 5 years ago by wdc@…

Take over as port maintainer, and use the patch file to correct the defect.

comment:1 Changed 5 years ago by Ionic (Mihai Moldovan)

Resolution: duplicate
Status: newclosed

Thanks.

Please don't open duplicate tickets, instead, attach your patches to the other still open ticket and tell us what to apply exactly.

Note that your Portfile patch mixes functional changes (e.g., the dependency updates etc.) and non-functional changes (maintainer change.)

Now that the maintainer change is obsolete, your patch won't apply cleanly. Thus, we prefer minimal patches and if needed multiple of them so one patch basically is one semantic entity.

comment:2 Changed 5 years ago by Ionic (Mihai Moldovan)

Description: modified (diff)
Note: See TracTickets for help on using tickets.