Opened 6 years ago

Closed 4 years ago

#48692 closed enhancement (wontfix)

port lint: add warning for revision: 0

Reported by: kurthindenburg (Kurt Hindenburg) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 2.3.3
Keywords: Cc:
Port:

Description

This patch add a warning to lint for 'revision: 0'

This received some negative feedback in IRC. I'm putting this here to get more feedback and if it should be trashed.

It was mentioned that there's no real harm in having it and sub-ports might have a legit reason for 'revision: 0'

Attachments (1)

portlint.diff (984 bytes) - added by kurthindenburg (Kurt Hindenburg) 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by kurthindenburg (Kurt Hindenburg)

Attachment: portlint.diff added

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

-1. I strive to deliberately put a revision line in every subport of every port that uses subports, even if it is "revision 0". This often successfully prevents inattentive committers from incorrectly increasing the revision of all of a port's subports when they should only be increasing the revision of one of the subports.

Some other maintainers like to keep "revision 0" in their ports as a reminder to themselves of the syntax to use.

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.