Opened 3 years ago

Closed 2 years ago

#48862 closed update (fixed)

astyle: update to 2.05.1

Reported by: jhi Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: wyuenho (Jimmy Yuen Ho Wong), kurthindenburg (Kurt Hindenburg)
Port: astyle

Description

http://astyle.sourceforge.net/notes.html

shows

Artistic Style 2.05.1 (December 2014)

while macports has

Artistic Style 2.04 (November 2013)

Attachments (2)

patch-Makefile.diff (2.8 KB) - added by ryandesign (Ryan Schmidt) 3 years ago.
astyle-2.05.1.diff (2.5 KB) - added by ryandesign (Ryan Schmidt) 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by ryandesign (Ryan Schmidt)

Cc: wyuenho@… added
Owner: changed from macports-tickets@… to ryandesign@…
Port: astyle added
Status: newassigned
Summary: astyle 2.05.1astyle: update to 2.05.1
Version: 2.3.3

Thanks for letting us know. I'll work on updating it.

Changed 3 years ago by ryandesign (Ryan Schmidt)

Attachment: patch-Makefile.diff added

comment:2 Changed 3 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

I'm attaching an update which works for me.

  • I updated the version and checksums, of course.
  • I adjusted the master_sites to avoid redirects.
  • The patchfile that changed JAVAHOME no longer applied; I used the java 1.0 portgroup in the hopes that its method of finding the Java installation is more robust than what we were previously doing.
  • I'm using the muniversal portgroup because building universal failed without it:
    ar: bin/libastyle.a is a fat file (use libtool(1) or lipo(1) and ar(1) on it)
    ar: bin/libastyle.a: Inappropriate file type or format
    
  • I removed the lib variant and made the port always build and install the libraries. The point of installing libraries is so that other software can use it. If that other software is in MacPorts, it needs to be able to assume the libraries are there, and not require the user to manually reinstall the port with the lib variant.
  • The libraries didn't have their install_name set, which is mandatory if other programs are going to be linked with them. I modified the Makefile patch to set the install_name, though the value to which I've set it is bad because it will presumably change with every astyle version. It should only change with every major astyle library version, but the astyle developers don't appear to be assigning library version numbers. This is not surprising since they also aren't providing Makefile targets for installing libraries; that's part of what the port adds in the Makefile patch. We should work with the developers of astyle to get our changes incorporated into their official sources and get them to correctly version the libraries. Ideally, they would switch their build system to autoconf which would automatically correctly handle these aspects of library building.

There is also an Xcode project in this version of astyle which can be used instead of the Makefile but I didn't look into it.

wyuenho, if there are no objections, I'm happy to commit these changes.

Changed 3 years ago by ryandesign (Ryan Schmidt)

Attachment: astyle-2.05.1.diff added

comment:3 Changed 2 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:4 Changed 2 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: assignedclosed

done r144506

Note: See TracTickets for help on using tickets.